Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-247: Fix in executeQuery function to use the bucket parameter #116

Closed
wants to merge 1 commit into from

Conversation

nabarunnag
Copy link
Contributor

GEODE-247: Fix in executeQuery function to use the bucket parameter and added tests cases for it.

  • modification of the function executeQuery to use the parameter bucket rather than ignoring it.
  • added integration test QueryWithBucketParameterIntegrationTest which tests variations in the bucket parameter.
  • code improvements done as per the review comments in github pull request
  • placed MyValue, createAndPopulateSet and populateRegion into a separate file TestData.java as being reused by two test cases to avoid redundant code
  • modified BugJUnitTest to import the TestData package and replaced for loops with IntStreams and lambda functions.

NOTE: This is an internal API which needs to be deprecated and replaced with an API without the bucket parameter.

…nd added tests cases for it.

* modification of the function executeQuery to use the parameter bucket rather than ignoring it.
* added integration test QueryWithBucketParameterIntegrationTest which tests variations in the  bucket parameter.
* code improvements done as per the review comments in github pull request
* placed MyValue, createAndPopulateSet and populateRegion into a separate file TestData.java as being reused by two test cases to avoid redundant code
* modified BugJUnitTest to import the TestData package and replaced for loops with IntStreams and lambda functions.

NOTE: This is an internal API which needs to be deprecated and replaced with an API without the bucket parameter.
@nabarunnag
Copy link
Contributor Author

Will resend the pull request after the Travis CI is operational again.

@nabarunnag nabarunnag closed this Mar 17, 2016
@nabarunnag nabarunnag deleted the feature/GEODE-247 branch March 17, 2016 23:51
bschuchardt pushed a commit to bschuchardt/geode that referenced this pull request Jul 10, 2020
retry creating the security group
robbadler pushed a commit to smgoller/geode that referenced this pull request Jul 12, 2022
…#116)

* processCpuTime no longer depends on deep reflection
* added VMStats50Test to verify fix
* removed add-opens for VMStats50 from product. It was still needed by the Jetty9CachingClientServerTest because of Jetty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant