GEODE-1296: change conditional in getRawBytes to assert #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated correspondiong unit test.
|
I think this should be changed to use the java "assert" keyword. The assertion should only be checked when assertions on the jvm are enabled. |
Fixed unit tests that spy getRawBytes that failed after making the above change.
| protected byte[] getRawBytes() { | ||
| assert !isCompressed(); | ||
| byte[] result = getCompressedBytes(); |
There was a problem hiding this comment.
Combine these two lines into "return getCompressedBytes();"
Made suggested changes and added @BeforeClass and @afterclass methods to enable Java assertions for testing, and restor the original state at the end of the test.
|
Precheckin passed with my most recent update. I think this one is ready to go now. |
|
The travis failure is a know intermittent issue in a new unit test. |
|
This was checked in by dschneider. Closing the PR |
robbadler
pushed a commit
to smgoller/geode
that referenced
this pull request
Jul 12, 2022
Changed several tests to make them stop spying concrete JDK classes. In Java 17, the packages of these classes are not open for reflection, causing Mockito to create spies that are incomplete and unusable.` Changed `ClientRegistrationEventQueueManagerTest` to subclass and override `java.util.concurrent.locks.ReentrantReadWriteLock` and`java.util.concurrent.locks.ReentrantReadWriteLock.ReadLock`. Changed `OverflowOplogFlushTest` to wrap the `java.nio.channels.FileChannel` instances in decorator classes that intercept and modify the channels' behavior. Changed `StartMemberUtilsTest` to use `mock(java.io.File.class)` instead of spying an existing instance. Even with these changes, `geode-test.gradle` must open these packages to tests, because `Jetty9CachingClientServerTest` still needs them to be opened. That will be fixed on a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made suggested change to getRawBytes. Updated corresponding unit test.
See review request https://reviews.apache.org/r/47479/