GEODE-1331: gfsh.bat on Windows is incorrect #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjduling
commented
May 26, 2016
kjduling
commented
- Renamed internal variable from CLASSPATH to DEPENDENCIES.
- Verified @SETLOCAL was not altering the System environment variables for the shell.
- Launch with -classpath param like the bash script does.
- Ensured command-line arguments match bash script's order of arguments.
* Renamed internal variable from CLASSPATH to DEPENDENCIES. * Verified @SETLOCAL was not altering the System environment variables for the shell. * Launch with -classpath param like the bash script does. * Ensured command-line arguments match bash script's order of arguments.
| ) | ||
| @"%GF_JAVA%" -Dgfsh=true -Dlog4j.configurationFile=classpath:log4j2-cli.xml %JAVA_ARGS% %LAUNCHER% %* |
There was a problem hiding this comment.
I am not very good at scripting language at all, but could the problem be fixed by just adding
-classpath %CLASSPATH% in the final command line?
It seems that we don't need to introduce DEPENDENCIES variable.
There was a problem hiding this comment.
It certainly could be done that way. I think I defined a new variable to be clear that we prepend to an existing CLASSPATH if there is one. If there isn't, then we only use what we define in the script.
Added some comments to clarify
robbadler
pushed a commit
to smgoller/geode
that referenced
this pull request
Jul 12, 2022
* Convert all references to apache/geode-benchmarks to gemfire/gemfire-benchmarks * Add github and gcp credentials in order to access protected items. * pass commercial repo credentials via ssh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.