-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-52: Remove @author tags from Java source #100
Conversation
2b1c405
to
6984f0a
Compare
In some cases, removing the @author tag leaves an empty javadoc. I think it would be better to remove the entire block for these cases. As an examnple: /**
|
+1 |
+1 I'm curious about why you left the json.org code alone, but not gemfire-joptsimple. Not a big deal because either way I think we have plans to get rid of both of those pieces of copied code. |
@@ -34,9 +34,6 @@ | |||
/** | |||
* Simple JavaBean domain object representing an owner. | |||
* | |||
* @author Ken Krebs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This files looks to be copied from spring-petclinic. We need to preserve the author tags and reapply the original copyright header (possibly update NOTICE as well).
6984f0a
to
7de92ac
Compare
Closing this pull-request as this work is re-done due to name change for sub-projects from Gemfire to Geode and the new re-work in on feature/GEODE-52 branch. |
* Fixed spotless configuration to support groovy and gradle * Spotless applied Co-authored-by: Murtuza Boxwala <[email protected]> Co-authored-by: Kamilla Aslami <[email protected]> Co-authored-by: Jacob Barrett <[email protected]>
I have automatically removed @author tags using unix command
find . -type f -print0 | xargs -0 sed -i /@author/d
I tested gradle build to check any compilation issues due to auto-remove a line from headers.
Also precheckin passed.