Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-52: Remove @author tags from Java source #100

Closed
wants to merge 2 commits into from

Conversation

sboorlagadda
Copy link
Member

  • removed @author tags except from java source copied from JSON.org
  • removed @author from java script files.

I have automatically removed @author tags using unix command find . -type f -print0 | xargs -0 sed -i /@author/d

I tested gradle build to check any compilation issues due to auto-remove a line from headers.

Also precheckin passed.

@pdxrunner
Copy link

In some cases, removing the @author tag leaves an empty javadoc. I think it would be better to remove the entire block for these cases.

As an examnple:
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java
index f7eaf2b..6b76c31 100644
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java
@@ -55,7 +55,6 @@
import com.gemstone.gemfire.internal.offheap.OffHeapRegionEntryHelper;

/**

  • * @author Suranjan Kumar

    */
    public class BucketRegionQueue extends AbstractBucketRegionQueue {

@sbawaska
Copy link

+1

@upthewaterspout
Copy link
Contributor

+1

I'm curious about why you left the json.org code alone, but not gemfire-joptsimple. Not a big deal because either way I think we have plans to get rid of both of those pieces of copied code.

@@ -34,9 +34,6 @@
/**
* Simple JavaBean domain object representing an owner.
*
* @author Ken Krebs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This files looks to be copied from spring-petclinic. We need to preserve the author tags and reapply the original copyright header (possibly update NOTICE as well).

Sai Boorlagadda added 2 commits February 22, 2016 13:59
* removed @author tags except from java source copied from JSON.org
* removed @author from java script files.
@sboorlagadda
Copy link
Member Author

Closing this pull-request as this work is re-done due to name change for sub-projects from Gemfire to Geode and the new re-work in on feature/GEODE-52 branch.

@sboorlagadda sboorlagadda deleted the GEODE-52 branch April 6, 2018 16:45
bschuchardt pushed a commit to bschuchardt/geode that referenced this pull request Jul 10, 2020
* Fixed spotless configuration to support groovy and gradle
* Spotless applied

Co-authored-by: Murtuza Boxwala <[email protected]>
Co-authored-by: Kamilla Aslami <[email protected]>
Co-authored-by: Jacob Barrett <[email protected]>
robbadler pushed a commit to smgoller/geode that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants