Pass mutable context to executeTransactionMessage callback#1302
Merged
lorisleiva merged 1 commit intoFeb 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 627e15e The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 2, 2026
Member
Author
BundleMonFiles updated (4)
Unchanged files (132)
Total files change +257B +0.06% Final result: ✅ View report in BundleMon website ➡️ |
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
from
c48ad05 to
40e12fa
Compare
lorisleiva
force-pushed
the
02-02-pass_mutable_context_to_executetransactionmessage_callback
branch
from
3f4dec2 to
1ad403f
Compare
Contributor
|
Documentation Preview: https://kit-docs-18shpvjzx-anza-tech.vercel.app |
Member
Author
|
Oh I guess I need to update some examples on that one as well. Will do that asap. EDIT: Done ✅ |
lorisleiva
force-pushed
the
02-02-pass_mutable_context_to_executetransactionmessage_callback
branch
2 times, most recently
from
7262be7 to
d8aa88e
Compare
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
from
40e12fa to
3ceef93
Compare
This was referenced Feb 3, 2026
Add
planType to distinguish between InstructionPlan, TransactionPlan and TransactionPlanResult
#1309
Merged
mcintyre94
approved these changes
Feb 3, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Nice, great tests and typetests too! I think this is a really nice way to structure executors now.
Member
Author
Merge activity
|
lorisleiva
changed the base branch from
01-30-reshape_successful_singletransactionplanresult_factories
to
graphite-base/1302
lorisleiva
force-pushed
the
graphite-base/1302
branch
from
3ceef93 to
5c810ac
Compare
lorisleiva
force-pushed
the
02-02-pass_mutable_context_to_executetransactionmessage_callback
branch
from
d8aa88e to
627e15e
Compare
lorisleiva
deleted the
02-02-pass_mutable_context_to_executetransactionmessage_callback
branch
This was referenced Feb 3, 2026
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
executeTransactionMessagecallback returns its result and context as a single object, which means none of that information is available when the callback throws. If an error occurs after signing but before confirming, for example, the transaction and signature are lost — making it difficult to debug failures or build recovery plans.Summary of Changes
The
executeTransactionMessagecallback now receives a mutable context object as its first argument. This context can be incrementally populated during execution (e.g. with the latest transaction message, the compiled transaction, or custom properties) and is preserved in the resultingSingleTransactionPlanResultregardless of the outcome — including failures.The callback signature changes from
(message, config)to(context, message, config)and now returns aSignature | Transactiondirectly instead of wrapping the result in an object. Custom context is set via mutation on the context argument rather than being returned.Relates to #1273