Extract base TransactionPlanResult context from generic TContext#1292
Merged
lorisleiva merged 1 commit intoFeb 3, 2026
Merged
Conversation
|
| Name | Type |
|---|---|
| @solana/instruction-plans | Major |
| @solana/kit | Major |
| @solana/accounts | Major |
| @solana/addresses | Major |
| @solana/assertions | Major |
| @solana/codecs-core | Major |
| @solana/codecs-data-structures | Major |
| @solana/codecs-numbers | Major |
| @solana/codecs-strings | Major |
| @solana/codecs | Major |
| @solana/compat | Major |
| @solana/errors | Major |
| @solana/fast-stable-stringify | Major |
| @solana/functional | Major |
| @solana/instructions | Major |
| @solana/keys | Major |
| @solana/nominal-types | Major |
| @solana/offchain-messages | Major |
| @solana/options | Major |
| @solana/plugin-core | Major |
| @solana/programs | Major |
| @solana/promises | Major |
| @solana/react | Major |
| @solana/rpc-api | Major |
| @solana/rpc-graphql | Major |
| @solana/rpc-parsed-types | Major |
| @solana/rpc-spec-types | Major |
| @solana/rpc-spec | Major |
| @solana/rpc-subscriptions-api | Major |
| @solana/rpc-subscriptions-channel-websocket | Major |
| @solana/rpc-subscriptions-spec | Major |
| @solana/rpc-subscriptions | Major |
| @solana/rpc-transformers | Major |
| @solana/rpc-transport-http | Major |
| @solana/rpc-types | Major |
| @solana/rpc | Major |
| @solana/signers | Major |
| @solana/subscribable | Major |
| @solana/sysvars | Major |
| @solana/transaction-confirmation | Major |
| @solana/transaction-messages | Major |
| @solana/transactions | Major |
| @solana/webcrypto-ed25519-polyfill | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Member
Author
This was referenced Feb 2, 2026
BundleMonFiles updated (1)
Unchanged files (135)
Total files change +21B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-dhhw11hk6-anza-tech.vercel.app |
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
acc8d58 to
11f6521
Compare
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
11f6521 to
b1b1ad4
Compare
lorisleiva
force-pushed
the
01-30-reshape_single_transactionplanresults_
branch
from
e2b92ca to
1f23642
Compare
lorisleiva
force-pushed
the
01-30-reshape_single_transactionplanresults_
branch
from
1f23642 to
fa87b2f
Compare
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
b1b1ad4 to
fb39372
Compare
This was referenced Feb 3, 2026
mcintyre94
approved these changes
Feb 3, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Looks good, matches what we discussed :)
This was referenced Feb 3, 2026
Add
planType to distinguish between InstructionPlan, TransactionPlan and TransactionPlanResult
#1309
Merged
Member
Author
Merge activity
|
lorisleiva
changed the base branch from
01-30-reshape_single_transactionplanresults_
to
graphite-base/1292
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
fb39372 to
e55f79d
Compare
lorisleiva
deleted the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Because the
Transactiontype is part of the base context forTransactionPlanResults, TypeScript struggles to inferTContextwhen multipleSuccessfulSingleTransactionPlanResultsare being created inside a parent plan (e.g. parallel or sequential).This is because the current implementation, makes
Transactionpart of the base type thatTContextextends.Summary of Changes
This PR makes the base type of
TContextan empty object (how it was before) and explicitly add{ transaction?, signature?, message? }to the single plan's contexts. This means TypeScript no longer need to infer theTransactiontypes inside of context objects.(TL;DR; for Callum: Option A → Option B).
Relates to #1273