Reshape successful SingleTransactionPlanResult factories#1293
Merged
lorisleiva merged 1 commit intoFeb 3, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 7d90e6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 2, 2026
Member
Author
BundleMonUnchanged files (136)
Total files change +31B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-4zb7xf887-anza-tech.vercel.app |
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
2 times, most recently
from
a39f30f to
c48ad05
Compare
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
acc8d58 to
11f6521
Compare
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
11f6521 to
b1b1ad4
Compare
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
from
c48ad05 to
40e12fa
Compare
lorisleiva
force-pushed
the
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
branch
from
b1b1ad4 to
fb39372
Compare
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
from
40e12fa to
3ceef93
Compare
This was referenced Feb 3, 2026
Add
planType to distinguish between InstructionPlan, TransactionPlan and TransactionPlanResult
#1309
Merged
Member
Author
Merge activity
|
lorisleiva
changed the base branch from
02-02-extract_base_transactionplanresult_context_from_generic_tcontext
to
graphite-base/1293
lorisleiva
force-pushed
the
01-30-reshape_successful_singletransactionplanresult_factories
branch
from
3ceef93 to
7d90e6f
Compare
lorisleiva
deleted the
01-30-reshape_successful_singletransactionplanresult_factories
branch
This was referenced Feb 3, 2026
Merged
Closed
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since we've reshaped the
SuccessfulSingleTransactionPlanResulttype, its factories also need a small reshape.Summary of Changes
successfulSingleTransactionPlanResultfunction is renamed tosuccessfulSingleTransactionPlanResultFromTransactionsince it uses atransactionobject to derive thesignaturerequirement.successfulSingleTransactionPlanResultFromSignaturefunction is renamed tosuccessfulSingleTransactionPlanResultsince it is the factory that is closest to the type itself. The signature must be provided as part of thecontextobject instead of a separate argument.Relates to #1273