Mark BaseTransactionMessage as deprecated#1146
Merged
Merged
Conversation
|
This was referenced Dec 18, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-flyikom35-anza-tech.vercel.app |
steveluscher
approved these changes
Dec 19, 2025
|
|
||
| /** | ||
| * @deprecated Use `TransactionMessage` instead. | ||
| * @todo In a future major version, remove the export |
Contributor
There was a problem hiding this comment.
I think the codebase already has // TODO(#XYZ) In a future... style comments where #XYZ is the GitHub issue number.
Also, I think it would be semver-esque to land this, do a release, then remove the word export with a major Changeset and do another release. They will have been done on the same day, but that still follows semver.
Thoughts?
Member
Author
There was a problem hiding this comment.
Yep I agree, if we actually remove the export completely then that's a major. I don't think we need to rush to do that though, I'm happy to just mark as deprecated and remove it at some point. Note that this stack doesn't completely eliminate BaseTransactionMessage from Kit, only where it affected these types. So there will be some more refactoring needed to completely remove it.
I'll open an issue for that and put it in this comment though.
mcintyre94
force-pushed
the
deprecate-base-tm
branch
from
f4ff4f7 to
cecbf6d
Compare
mcintyre94
added a commit
that referenced
this pull request
Jan 7, 2026
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We exported
BaseTransactionMessage, but as this stack shows in practice it's strictly better to useTransactionMessageinstead.Summary of Changes
BaseTransactionMessageas deprecated. This will encourage Kit users (and us) to gradually migrate toTransactionMessageBaseTransactionMessageand just have it as implementation detail for the structure ofTransactionMessage