Remove BaseTransactionMessage from transaction-message blockhash functions#1134
Merged
Conversation
|
Member
Author
This was referenced Dec 17, 2025
mcintyre94
commented
Dec 17, 2025
| 'lifetimeConstraint' | ||
| >; | ||
| export type ExcludeTransactionMessageLifetime<TTransactionMessage extends TransactionMessage> = | ||
| TTransactionMessage extends unknown ? Omit<TTransactionMessage, 'lifetimeConstraint'> : never; |
Member
Author
There was a problem hiding this comment.
Flagging this here, but this pattern is used a lot through the stack
This is a trick to make Typescript distribute over the union type, ie not collapse the version. We use it in this stack whenever we use Omit<TTransactionVersion, ...>
mcintyre94
force-pushed
the
tx-msg-blockhash-type
branch
2 times, most recently
from
7ba1862 to
bd589ff
Compare
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
force-pushed
the
tx-msg-blockhash-type
branch
from
bd589ff to
875e87c
Compare
Contributor
|
Documentation Preview: https://kit-docs-p568lwhml-anza-tech.vercel.app |
mcintyre94
force-pushed
the
decompile-with-lookups-type
branch
from
901a7cd to
d76d1f2
Compare
mcintyre94
force-pushed
the
tx-msg-blockhash-type
branch
from
875e87c to
6d29dab
Compare
mcintyre94
force-pushed
the
tx-msg-blockhash-type
branch
from
6d29dab to
f01cc24
Compare
mcintyre94
force-pushed
the
decompile-with-lookups-type
branch
from
d76d1f2 to
eb5d742
Compare
Member
Author
Merge activity
|
lorisleiva
approved these changes
Jan 7, 2026
mcintyre94
changed the base branch from
decompile-with-lookups-type
to
graphite-base/1134
mcintyre94
force-pushed
the
tx-msg-blockhash-type
branch
from
f01cc24 to
1d58d08
Compare
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Our
TransactionMessagefunctions operate onBaseTransactionMessageinstead ofTransactionMessage, which limits the ability to type narrow the resulting transaction messagesSummary of Changes
TransactionMessagein input/output typesPart of a stack that eventually supersedes #1103