Add a typetest for types flowing through transaction message functions#1139
Merged
Conversation
🦋 Changeset detectedLatest commit: 0e7de2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Dec 17, 2025
Member
Author
This was referenced Dec 17, 2025
mcintyre94
force-pushed
the
tx-msg-fee-signer
branch
from
4c779df to
8342c4b
Compare
mcintyre94
force-pushed
the
scenario-typetest
branch
2 times, most recently
from
530dfbe to
9308170
Compare
mcintyre94
force-pushed
the
tx-msg-fee-signer
branch
from
8342c4b to
591e4e4
Compare
BundleMonUnchanged files (136)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-bkq5fpacd-anza-tech.vercel.app |
mcintyre94
force-pushed
the
scenario-typetest
branch
from
9308170 to
be1d465
Compare
mcintyre94
force-pushed
the
tx-msg-fee-signer
branch
from
591e4e4 to
b59f5dc
Compare
mcintyre94
commented
Dec 17, 2025
| '@solana/instruction-plans': minor | ||
| '@solana/transactions': minor | ||
| '@solana/signers': minor | ||
| '@solana/kit': minor |
Member
Author
There was a problem hiding this comment.
Flagging this - I think this is debatable on minor or major. TransactionMessage is compatible with BaseTransactionMessage, so app code isn't going to break. But if you have functions/types that use BaseTransactionMessage you may need to change them to use TransactionMessage in order to be compatible with our helper functions.
steveluscher
approved these changes
Dec 18, 2025
mcintyre94
force-pushed
the
scenario-typetest
branch
from
be1d465 to
dfb68fb
Compare
mcintyre94
force-pushed
the
tx-msg-fee-signer
branch
from
b59f5dc to
401bd1f
Compare
mcintyre94
changed the base branch from
tx-msg-fee-signer
to
graphite-base/1139
mcintyre94
force-pushed
the
scenario-typetest
branch
from
dfb68fb to
fe00744
Compare
mcintyre94
changed the base branch from
graphite-base/1139
to
deprecate-base-tm
mcintyre94
force-pushed
the
deprecate-base-tm
branch
from
f4ff4f7 to
cecbf6d
Compare
mcintyre94
force-pushed
the
scenario-typetest
branch
from
fe00744 to
d5eb6f5
Compare
mcintyre94
force-pushed
the
scenario-typetest
branch
from
d5eb6f5 to
2c5861f
Compare
mcintyre94
force-pushed
the
tx-msg-fee-signer
branch
from
651c2cd to
487cd67
Compare
Member
Author
Merge activity
|
lorisleiva
approved these changes
Jan 7, 2026
mcintyre94
changed the base branch from
tx-msg-fee-signer
to
graphite-base/1139
mcintyre94
force-pushed
the
scenario-typetest
branch
from
2c5861f to
0e7de2b
Compare
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced Jan 7, 2026
Merged
Merged
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new typetest that does the following:
decompileTransactionMessageFetchingLookupTablesNote that we don't have any typetests like this that combine functionality from multiple packages. I've put this in
packages/kit/__typetests__/scenarios, but don't feel strongly about where it should live. I do think it's important to have this as part of the repo though because it would be very easy to introduce a regression.Supersedes #1103, by avoiding the need to introduce assertion functions