Remove BaseTransactionMessage from transaction-message instruction functions by mcintyre94 · Pull Request #1137 · anza-xyz/kit

mcintyre94 · 2025-12-17T10:51:40Z

Problem

Our TransactionMessage functions operate on BaseTransactionMessage instead of TransactionMessage, which limits the ability to type narrow the resulting transaction messages

Summary of Changes

Change to use TransactionMessage in input/output types

Part of a stack that eventually supersedes #1103

changeset-bot · 2025-12-17T10:51:45Z

⚠️ No Changeset found

Latest commit: 1e9bbdf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mcintyre94 · 2025-12-17T10:51:52Z

bundlemon · 2025-12-17T11:45:15Z

BundleMon

Unchanged files (136)

Status	Path	Size	Limits
✅	@solana/kit production bundle _{kit/dist/index.production.min.js}	39.24KB	-
✅	rpc-graphql/dist/index.browser.mjs	18.82KB	-
✅	rpc-graphql/dist/index.native.mjs	18.81KB	-
✅	rpc-graphql/dist/index.node.mjs	18.81KB	-
✅	errors/dist/index.node.mjs	17.22KB	-
✅	errors/dist/index.browser.mjs	17.2KB	-
✅	errors/dist/index.native.mjs	17.2KB	-
✅	transaction-messages/dist/index.browser.mjs	7.29KB	-
✅	transaction-messages/dist/index.native.mjs	7.29KB	-
✅	transaction-messages/dist/index.node.mjs	7.29KB	-
✅	offchain-messages/dist/index.browser.mjs	4.89KB	-
✅	offchain-messages/dist/index.native.mjs	4.89KB	-
✅	offchain-messages/dist/index.node.mjs	4.89KB	-
✅	codecs-data-structures/dist/index.browser.mjs	4.69KB	-
✅	codecs-data-structures/dist/index.native.mjs	4.69KB	-
✅	codecs-data-structures/dist/index.node.mjs	4.69KB	-
✅	instruction-plans/dist/index.browser.mjs	3.81KB	-
✅	instruction-plans/dist/index.native.mjs	3.81KB	-
✅	instruction-plans/dist/index.node.mjs	3.81KB	-
✅	codecs-core/dist/index.browser.mjs	3.61KB	-
✅	codecs-core/dist/index.native.mjs	3.61KB	-
✅	codecs-core/dist/index.node.mjs	3.61KB	-
✅	webcrypto-ed25519-polyfill/dist/index.node.mj s	3.61KB	-
✅	webcrypto-ed25519-polyfill/dist/index.browser .mjs	3.59KB	-
✅	webcrypto-ed25519-polyfill/dist/index.native. mjs	3.57KB	-
✅	rpc-subscriptions/dist/index.browser.mjs	3.37KB	-
✅	rpc-subscriptions/dist/index.node.mjs	3.34KB	-
✅	rpc-subscriptions/dist/index.native.mjs	3.31KB	-
✅	rpc-transformers/dist/index.browser.mjs	2.93KB	-
✅	rpc-transformers/dist/index.native.mjs	2.93KB	-
✅	rpc-transformers/dist/index.node.mjs	2.93KB	-
✅	addresses/dist/index.browser.mjs	2.93KB	-
✅	addresses/dist/index.native.mjs	2.92KB	-
✅	addresses/dist/index.node.mjs	2.92KB	-
✅	signers/dist/index.browser.mjs	2.9KB	-
✅	signers/dist/index.native.mjs	2.9KB	-
✅	signers/dist/index.node.mjs	2.9KB	-
✅	transactions/dist/index.browser.mjs	2.87KB	-
✅	transactions/dist/index.native.mjs	2.86KB	-
✅	transactions/dist/index.node.mjs	2.86KB	-
✅	codecs-strings/dist/index.browser.mjs	2.53KB	-
✅	codecs-strings/dist/index.node.mjs	2.49KB	-
✅	codecs-strings/dist/index.native.mjs	2.45KB	-
✅	transaction-confirmation/dist/index.node.mjs	2.41KB	-
✅	transaction-confirmation/dist/index.native.mj s	2.36KB	-
✅	transaction-confirmation/dist/index.browser.m js	2.35KB	-
✅	sysvars/dist/index.browser.mjs	2.35KB	-
✅	sysvars/dist/index.native.mjs	2.34KB	-
✅	sysvars/dist/index.node.mjs	2.34KB	-
✅	react/dist/index.browser.mjs	2.31KB	-
✅	react/dist/index.native.mjs	2.31KB	-
✅	react/dist/index.node.mjs	2.31KB	-
✅	rpc-subscriptions-spec/dist/index.node.mjs	2.18KB	-
✅	rpc-subscriptions-spec/dist/index.native.mjs	2.13KB	-
✅	rpc-subscriptions-spec/dist/index.browser.mjs	2.13KB	-
✅	keys/dist/index.browser.mjs	2.1KB	-
✅	keys/dist/index.native.mjs	2.1KB	-
✅	keys/dist/index.node.mjs	2.1KB	-
✅	rpc/dist/index.node.mjs	1.95KB	-
✅	codecs-numbers/dist/index.browser.mjs	1.95KB	-
✅	codecs-numbers/dist/index.native.mjs	1.95KB	-
✅	codecs-numbers/dist/index.node.mjs	1.94KB	-
✅	rpc-transport-http/dist/index.browser.mjs	1.91KB	-
✅	rpc-transport-http/dist/index.native.mjs	1.9KB	-
✅	rpc/dist/index.native.mjs	1.81KB	-
✅	rpc/dist/index.browser.mjs	1.8KB	-
✅	subscribable/dist/index.node.mjs	1.8KB	-
✅	subscribable/dist/index.native.mjs	1.75KB	-
✅	subscribable/dist/index.browser.mjs	1.74KB	-
✅	rpc-transport-http/dist/index.node.mjs	1.72KB	-
✅	kit/dist/index.browser.mjs	1.69KB	-
✅	kit/dist/index.native.mjs	1.69KB	-
✅	kit/dist/index.node.mjs	1.69KB	-
✅	rpc-types/dist/index.browser.mjs	1.53KB	-
✅	rpc-types/dist/index.native.mjs	1.53KB	-
✅	rpc-types/dist/index.node.mjs	1.53KB	-
✅	rpc-subscriptions-channel-websocket/dist/inde x.node.mjs	1.33KB	-
✅	rpc-subscriptions-channel-websocket/dist/inde x.native.mjs	1.27KB	-
✅	rpc-subscriptions-channel-websocket/dist/inde x.browser.mjs	1.26KB	-
✅	options/dist/index.browser.mjs	1.18KB	-
✅	options/dist/index.native.mjs	1.18KB	-
✅	options/dist/index.node.mjs	1.17KB	-
✅	accounts/dist/index.browser.mjs	1.13KB	-
✅	accounts/dist/index.native.mjs	1.12KB	-
✅	accounts/dist/index.node.mjs	1.12KB	-
✅	rpc-api/dist/index.browser.mjs	976B	-
✅	rpc-api/dist/index.native.mjs	975B	-
✅	rpc-api/dist/index.node.mjs	973B	-
✅	compat/dist/index.browser.mjs	969B	-
✅	compat/dist/index.native.mjs	968B	-
✅	compat/dist/index.node.mjs	966B	-
✅	rpc-spec-types/dist/index.browser.mjs	962B	-
✅	rpc-spec-types/dist/index.native.mjs	961B	-
✅	rpc-spec-types/dist/index.node.mjs	959B	-
✅	rpc-subscriptions-api/dist/index.native.mjs	870B	-
✅	rpc-subscriptions-api/dist/index.node.mjs	869B	-
✅	rpc-subscriptions-api/dist/index.browser.mjs	868B	-
✅	rpc-spec/dist/index.browser.mjs	852B	-
✅	rpc-spec/dist/index.native.mjs	851B	-
✅	rpc-spec/dist/index.node.mjs	850B	-
✅	promises/dist/index.browser.mjs	799B	-
✅	promises/dist/index.native.mjs	798B	-
✅	promises/dist/index.node.mjs	797B	-
✅	assertions/dist/index.browser.mjs	783B	-
✅	instructions/dist/index.browser.mjs	771B	-
✅	instructions/dist/index.native.mjs	770B	-
✅	instructions/dist/index.node.mjs	768B	-
✅	fast-stable-stringify/dist/index.browser.mjs	726B	-
✅	fast-stable-stringify/dist/index.native.mjs	725B	-
✅	assertions/dist/index.native.mjs	724B	-
✅	fast-stable-stringify/dist/index.node.mjs	724B	-
✅	assertions/dist/index.node.mjs	723B	-
✅	programs/dist/index.browser.mjs	329B	-
✅	plugin-core/dist/index.browser.mjs	328B	-
✅	programs/dist/index.native.mjs	327B	-
✅	plugin-core/dist/index.native.mjs	326B	-
✅	programs/dist/index.node.mjs	325B	-
✅	plugin-core/dist/index.node.mjs	324B	-
✅	event-target-impl/dist/index.node.mjs	230B	-
✅	functional/dist/index.browser.mjs	154B	-
✅	functional/dist/index.native.mjs	152B	-
✅	text-encoding-impl/dist/index.native.mjs	152B	-
✅	functional/dist/index.node.mjs	151B	-
✅	codecs/dist/index.browser.mjs	137B	-
✅	codecs/dist/index.native.mjs	136B	-
✅	codecs/dist/index.node.mjs	134B	-
✅	event-target-impl/dist/index.browser.mjs	133B	-
✅	ws-impl/dist/index.node.mjs	131B	-
✅	text-encoding-impl/dist/index.browser.mjs	122B	-
✅	text-encoding-impl/dist/index.node.mjs	119B	-
✅	ws-impl/dist/index.browser.mjs	113B	-
✅	crypto-impl/dist/index.node.mjs	111B	-
✅	crypto-impl/dist/index.browser.mjs	109B	-
✅	rpc-parsed-types/dist/index.browser.mjs	66B	-
✅	rpc-parsed-types/dist/index.native.mjs	65B	-
✅	rpc-parsed-types/dist/index.node.mjs	63B	-

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

github-actions · 2025-12-17T11:51:23Z

Documentation Preview: https://kit-docs-my47431h0-anza-tech.vercel.app

steveluscher

So nice already having typetests so you can do a refactor like this.

mcintyre94 · 2026-01-07T08:35:05Z

Merge activity

Jan 7, 8:35 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Jan 7, 8:56 AM UTC: Graphite couldn't merge this pull request because a downstack PR Improve typing of return from decompileTransactionMessage #1132 failed to merge.
Jan 7, 10:12 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Jan 7, 10:30 AM UTC: Graphite rebased this pull request as part of a merge.
Jan 7, 10:32 AM UTC: @mcintyre94 merged this pull request with Graphite.

…nctions

github-actions · 2026-01-22T08:12:07Z

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

This was referenced Dec 17, 2025

Improve typing of return from decompileTransactionMessage #1132

Merged

Improve typing of return from decompileTransactionMessageFetchingLookupTables #1133

Merged

Remove BaseTransactionMessage from transaction-message blockhash functions #1134

Merged

mcintyre94 force-pushed the tx-msg-feepayer branch from fd1f734 to fabf81c Compare December 17, 2025 11:14

mcintyre94 force-pushed the tx-msg-instructions branch 2 times, most recently from f34da79 to d7e6464 Compare December 17, 2025 11:44

mcintyre94 force-pushed the tx-msg-feepayer branch from fabf81c to a924c27 Compare December 17, 2025 11:44

mcintyre94 force-pushed the tx-msg-instructions branch from d7e6464 to c25035a Compare December 17, 2025 12:12

mcintyre94 force-pushed the tx-msg-feepayer branch from a924c27 to 8d313ba Compare December 17, 2025 12:12

steveluscher marked this pull request as ready for review December 18, 2025 07:34

steveluscher approved these changes Dec 18, 2025

View reviewed changes

mcintyre94 force-pushed the tx-msg-instructions branch from c25035a to 71e3551 Compare December 18, 2025 08:40

mcintyre94 force-pushed the tx-msg-feepayer branch from 8d313ba to 18180b3 Compare December 18, 2025 08:40

mcintyre94 mentioned this pull request Dec 18, 2025

Mark BaseTransactionMessage as deprecated #1146

Merged

github-actions Bot added the stale label Jan 2, 2026

mcintyre94 force-pushed the tx-msg-feepayer branch from 18180b3 to 79da0ed Compare January 6, 2026 18:08

mcintyre94 force-pushed the tx-msg-instructions branch from 71e3551 to 4e513fa Compare January 6, 2026 18:08

mcintyre94 removed the stale label Jan 6, 2026

lorisleiva approved these changes Jan 7, 2026

View reviewed changes

mcintyre94 changed the base branch from tx-msg-feepayer to graphite-base/1137 January 7, 2026 10:25

mcintyre94 changed the base branch from graphite-base/1137 to main January 7, 2026 10:28

Remove BaseTransactionMessage from transaction-message instruction fu…

1e9bbdf

…nctions

mcintyre94 force-pushed the tx-msg-instructions branch from 4e513fa to 1e9bbdf Compare January 7, 2026 10:29

mcintyre94 merged commit ff0a7d6 into main Jan 7, 2026
11 of 13 checks passed

mcintyre94 deleted the tx-msg-instructions branch January 7, 2026 10:32

github-actions Bot locked as resolved and limited conversation to collaborators Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove BaseTransactionMessage from transaction-message instruction functions#1137

Remove BaseTransactionMessage from transaction-message instruction functions#1137
mcintyre94 merged 1 commit into
mainfrom
tx-msg-instructions

mcintyre94 commented Dec 17, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

mcintyre94 commented Dec 17, 2025 •

edited

Loading

Uh oh!

bundlemon Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

steveluscher left a comment •

edited

Loading

Uh oh!

mcintyre94 commented Jan 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mcintyre94 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

changeset-bot Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

mcintyre94 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bundlemon Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BundleMon

Uh oh!

github-actions Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steveluscher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcintyre94 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions Bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mcintyre94 commented Dec 17, 2025 •

edited

Loading

changeset-bot Bot commented Dec 17, 2025 •

edited

Loading

mcintyre94 commented Dec 17, 2025 •

edited

Loading

bundlemon Bot commented Dec 17, 2025 •

edited

Loading

github-actions Bot commented Dec 17, 2025 •

edited

Loading

steveluscher left a comment •

edited

Loading

mcintyre94 commented Jan 7, 2026 •

edited

Loading