Skip to content

v2.2: Remove conditional feature as it is not supported (backport of #6577)#6606

Closed
mergify[bot] wants to merge 2 commits intov2.2from
mergify/bp/v2.2/pr-6577
Closed

v2.2: Remove conditional feature as it is not supported (backport of #6577)#6606
mergify[bot] wants to merge 2 commits intov2.2from
mergify/bp/v2.2/pr-6577

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jun 16, 2025

Problem

Adding dependencies based on configuration values is currently not supported. Cargo generates an error when trying to build this crate (see #6440 (comment))

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.

Summary of Changes

Remove condition and add feature directly to dependency.

Fixes #


This is an automatic backport of pull request #6577 done by [Mergify](https://mergify.com).

* remove condition as it is not supported

* remove useless whitespace to fix sort

(cherry picked from commit 51c33c2)

# Conflicts:
#	svm/Cargo.toml
@mergify mergify Bot requested a review from a team as a code owner June 16, 2025 18:56
@mergify mergify Bot added the conflicts label Jun 16, 2025
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jun 16, 2025

Cherry-pick of 51c33c2 has failed:

On branch mergify/bp/v2.2/pr-6577
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 51c33c2f3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   svm/Cargo.toml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.4%. Comparing base (2b7a363) to head (a555a39).
⚠️ Report is 19 commits behind head on v2.2.

Additional details and impacted files
@@           Coverage Diff            @@
##             v2.2    #6606    +/-   ##
========================================
  Coverage    83.3%    83.4%            
========================================
  Files         807      807            
  Lines      373498   373498            
========================================
+ Hits       311484   311603   +119     
+ Misses      62014    61895   -119     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mircea-c mircea-c closed this Jun 25, 2025
@mircea-c mircea-c deleted the mergify/bp/v2.2/pr-6577 branch June 25, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants