v2.2: Remove conditional feature as it is not supported (backport of #6577)#6606
Closed
mergify[bot] wants to merge 2 commits intov2.2from
Closed
v2.2: Remove conditional feature as it is not supported (backport of #6577)#6606mergify[bot] wants to merge 2 commits intov2.2from
mergify[bot] wants to merge 2 commits intov2.2from
Conversation
* remove condition as it is not supported * remove useless whitespace to fix sort (cherry picked from commit 51c33c2) # Conflicts: # svm/Cargo.toml
Author
|
Cherry-pick of 51c33c2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.2 #6606 +/- ##
========================================
Coverage 83.3% 83.4%
========================================
Files 807 807
Lines 373498 373498
========================================
+ Hits 311484 311603 +119
+ Misses 62014 61895 -119 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adding dependencies based on configuration values is currently not supported. Cargo generates an error when trying to build this crate (see #6440 (comment))
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies
The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.Summary of Changes
Remove condition and add feature directly to dependency.
Fixes #
This is an automatic backport of pull request #6577 done by [Mergify](https://mergify.com).