v2.3: Remove conditional feature as it is not supported (backport of #6577)

[mergify]

Problem

Adding dependencies based on configuration values is currently not supported. Cargo generates an error when trying to build this crate (see #6440 (comment))

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.

Summary of Changes

Remove condition and add feature directly to dependency.

Fixes #

---

This is an automatic backport of pull request #6577 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 51c33c2 has failed:

On branch mergify/bp/v2.3/pr-6577
Your branch is up to date with 'origin/v2.3'.

You are currently cherry-picking commit 51c33c2f3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   svm/Cargo.toml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (3e1c3a2) to head (f1bd7bc).

Additional details and impacted files

@@            Coverage Diff            @@
##             v2.3    #6607     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379542   379542             
=========================================
- Hits       314575   314524     -51     
- Misses      64967    65018     +51     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[t-nelson]

the dependency should be redeclared with the feature flag in [dev-dependencies], not added to prod [dependencies]

[mircea-c]

Crate publishing fails if the feature is not added to [dependencies]

[t-nelson]

something else is wrong then. this should never be used in prod

[t-nelson]

p sure this should be gated by the cargo feature, not debug_assertions.

agave/svm/src/transaction_processor.rs

Lines 863 to 864 in 3281f61

	#[cfg(debug_assertions)]
	transaction_context.set_signature(tx.signature());

don't see any other usage of the tx-ctx symbols behind that feature

[t-nelson]

honestly deleting the Signature bs might be the way to go? don't see it touched anywhere

[t-nelson]

@Lichtso @LucasSte is this debug signature stuff dead code? can't find it used otherwise in monorepo or sdk

[Lichtso]

https://github.com/anza-xyz/agave/blob/master/transaction-context/src/lib.rs#L180C5-L186C26

But yes, can be deleted if it causes too much trouble with dependencies.

[t-nelson]

https://github.com/anza-xyz/agave/blob/master/transaction-context/src/lib.rs#L180C5-L186C26

sure. saw that. was more concerned that it's not actually read anywhere in the codebase other than implicitly through PartialEq, but don't actually see an instance of (a sanely named instantiation of) TransactionContext equality comparison in a debug_assert

But yes, can be deleted if it causes too much trouble with dependencies.

[mircea-c]

Closing this as the code has been removed by #6647