Skip to content

Remove conditional feature as it is not supported#6577

Merged
mircea-c merged 2 commits intoanza-xyz:masterfrom
mircea-c:ci/svm-deps-fix
Jun 16, 2025
Merged

Remove conditional feature as it is not supported#6577
mircea-c merged 2 commits intoanza-xyz:masterfrom
mircea-c:ci/svm-deps-fix

Conversation

@mircea-c
Copy link
Copy Markdown

Problem

Adding dependencies based on configuration values is currently not supported. Cargo generates an error when trying to build this crate (see #6440 (comment))

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.

Summary of Changes

Remove condition and add feature directly to dependency.

Fixes #

@mircea-c mircea-c self-assigned this Jun 13, 2025
@mircea-c mircea-c requested a review from a team as a code owner June 13, 2025 16:55
LucasSte
LucasSte previously approved these changes Jun 13, 2025
@LucasSte
Copy link
Copy Markdown

The toml file needs to be sorted for CI to pass.

@mircea-c mircea-c added the v2.2 label Jun 13, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 13, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 13, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (3804f39) to head (719d2cf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6577   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         849      849           
  Lines      379244   379244           
=======================================
+ Hits       314106   314147   +41     
+ Misses      65138    65097   -41     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mircea-c mircea-c requested a review from LucasSte June 13, 2025 20:23
@mircea-c mircea-c merged commit 51c33c2 into anza-xyz:master Jun 16, 2025
38 checks passed
@mircea-c mircea-c deleted the ci/svm-deps-fix branch June 16, 2025 18:56
mergify Bot pushed a commit that referenced this pull request Jun 16, 2025
* remove condition as it is not supported

* remove useless whitespace to fix sort

(cherry picked from commit 51c33c2)

# Conflicts:
#	svm/Cargo.toml
mergify Bot pushed a commit that referenced this pull request Jun 16, 2025
* remove condition as it is not supported

* remove useless whitespace to fix sort

(cherry picked from commit 51c33c2)

# Conflicts:
#	svm/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants