Remove conditional feature as it is not supported#6577
Remove conditional feature as it is not supported#6577mircea-c merged 2 commits intoanza-xyz:masterfrom
Conversation
|
The toml file needs to be sorted for CI to pass. |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
7357627 to
26aff6e
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6577 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 849 849
Lines 379244 379244
=======================================
+ Hits 314106 314147 +41
+ Misses 65138 65097 -41 🚀 New features to boost your workflow:
|
* remove condition as it is not supported * remove useless whitespace to fix sort (cherry picked from commit 51c33c2) # Conflicts: # svm/Cargo.toml
* remove condition as it is not supported * remove useless whitespace to fix sort (cherry picked from commit 51c33c2) # Conflicts: # svm/Cargo.toml
Problem
Adding dependencies based on configuration values is currently not supported. Cargo generates an error when trying to build this crate (see #6440 (comment))
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies
The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.Summary of Changes
Remove condition and add feature directly to dependency.
Fixes #