[DO NOT SUBMIT] this is a test #8168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7923) * rewrite error message * update * ticks
We moved DEVELOPING.md to the contributing folder but didn't update many of the relative links accordingly.
* first pass at adding/removing subtrees * tests passing * Add ability to add and remove bindings in the subtree rooted at a specific node * lint fixes * merge conflict * ci issues * some cleanup * pr comments * pr comments, new method of removing bindings for node and its children * fix some lint warnings * test and lint fixes * mutation observer * update comments * add observer * naive implementation * cleanup * clean * cleanup bind impl * very simple example of bind in a template * pr comments * lint errors * pr comments * cleanup * lint errors * pr comments * pr comments and lint warnings * typo * comments * more lint warnings * pr comment * change README * cleanup * pr comments * pr comments 2 * lint warnings * don't use foreach on Nodelist * casting * more ci warnings * even more ci warnings * even more ci warnings * even more ci issues * even more ci comments * even more ci issues * pr comments * more pr comments * fix refactoring oversight * pr comments * pr comments * merge * pr comments * ci issues * pr comments * assertElement * pr comments * typo * updating sanitizer * fixing up sanitizer test * pr comments * pr comments * expanded on amp-mustache tests * pr comments * remove class from whitelist * restore whole sandbox * update mustache validator test and output * pr comments
* carousel test, still in progress * caorusel integration test working * cleanup * cleanup2 * lint errors * made promises on bindimpl private * lint error * pr comment * wrong path for closure annotation * changing some type annotations * pr comments * lint errors * retry * cleanup * cleanup * don't access private property * missing semicolon * class binding test * pr comments * timeout for sauce labs * title * merge * pr comment * cleanup * pr comments * cleanup * clean * clean * renaming to match other integration tests, comment about setup of bind in beforeEach * more commenting * pr comment
* Consolidated frame attribute assigning. * Fixed broken test infrastructure; Fixed attributes * Add iframe-attributes.js to whitelist for getModeObject
* Update how creative agencies can get involved * Update a4a-readme.md
…7610) * Pass ampcontext file path name down on name. * Changed to use urls.cdn * Consolidated strings to one line * Concatenated strings
…ormatted properly (#7977)
* force collapse sticky-ad * use getAdContainer * s * store pre calculate value * fix lint
* cambios en pagina de test de amp * fix script issues * fix script issues * fix script issues * fix script issues * fix script issues * fix code issues 1.0 * fix code issues 2.0 * fix code issues 3.0 * fix code issues 4.0 * fix code issues 5.0 * final code checked and appoved uploaded * add renderStartImplemented: true in config.js * adding example and documentation * changing testing evironment and fixing bugs caused by that changes * changes in 3p reverted, and double quote all plugin set up parameters * final code checked and appoved uploaded * remove blank lines and spaces * reverting remote and frame max to original status * removing trailing spaces in sunmedia.js * removing trailing spaces in sunmedia.js * removing trailing spaces in sunmedia.js * removing trailing spaces in sunmedia.js
* add generator code * generate validator protoascii * simplify test * add validator * apply validation spec changes
* initial commit for turing machine example * initial commit for bind game example * flip chance conditional, tweak generation logic * add win/loss message and new game button * kevin's comments * prettify games with mdl
…han document body (#8013)
- Removes a typo in the Nokta's amp-ad documentation.
Add a backup timer for non-animation vsync tasks. This ensures that non-animation tasks still eventually (timer at 2.5X normal rAF time) execute when we somehow failed to detect that we aren't visible. Fixes #7589
* store last tick value * fix type check * remove opt- * rename
While there are some legit reasons to do this, we should disallow this by default and point people to the config based option instead.
Under `attributes` prepend `data-` to the attribute names.
* Send RTV version number along with CSI pings. * fix tests
Clarify that removing `nonce` is only the attribute `nonce` and remove the confusion around the inserted `meta` tag for nonce.
* Toggle visibility-v3 via flag * allow for allow-doc-opt-in
* support binding to amp-brightcove's src attrs * add integration test
* Fix typo: dumpSaxAsJson should correspond to provide. * Revision bump * Revision bump * Update spec urls to more canonical location. * Add a test case for `<amp-ad>` * Emit one error per attribute, rather than stop at the first error found for any attribute in an HTML tag. * Allow `<iframe>` tag within `<noscript>` section, suggesting `<amp-iframe>` in other contexts. * Revision bump for `<amp-facebook-comments>`. * Error categorization had a conditional branch which no longer could be reached, due to changes to the way we generated errors. This CL removes that extra code. * Revision bump * Revision bump * Blacklist meta name=(amp-.*|amp4ads-.*) and whitelist specific instances. * Make extensions a first-class validator concept with a new ExtensionSpec. * Fix validator-amp-mustache output file.
* support binding to amp-youtube's data-videoid * unit test * use loadVideoById instead of changing iframe src * fix lint error * add integration test
* Add amp-call-tracking to gulpfile * Fix type checks
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please pick a meaningful title for your pull request using sentence case.
Do not overuse punctuation in the title like
(chore):. If it is helpful feel free to start with a project name, though, likeProjectX: Implement some feature.Title instructions above.
Enter a succinct description of what is achieved by the PR. Ideally describe why the change is being made.
Bullet points like
really help with making this more readable.
Fixes/Closes/Related-to #1 (enter issue number, except in rare cases where none exists).