Amp-Video Bind Integration Test #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmh287
force-pushed
the
bind_integration_tests4
branch
from
f126383
to
58c96e8
Compare
kmh287
force-pushed
the
bind_integration_tests4
branch
from
1d258f9
to
6a24bd1
Compare
|
@choumx PTAL |
dreamofabear
approved these changes
Mar 9, 2017
| .equal('https://www.google.com/unbound.webm'); | ||
| button.click(); | ||
| return waitForBindApplication().then(() => { | ||
| // Only HTTPS is allowed |
There was a problem hiding this comment.
Shouldn't blocks only be indented by two?
EDIT: Oh, you mean the .equal part. Done.
There was a problem hiding this comment.
No I meant this comment. Overflow should be +4 spaces so that change should be reverted.
Nitty nit nits.
There was a problem hiding this comment.
Overflow is at +4. Will fix the comment on this PR
kmh287
added a commit
to kmh287/amphtml
that referenced
this pull request
Mar 13, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an integration test for amp-bind with amp-video. I've tested the
src,alt, andcontrolsattributes, and forsrc, tested allowed protocols and blocked URLs..