InOb polyfill trigger new added element w/o tick #8100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files.
|
dvoytenko
approved these changes
Mar 13, 2017
| this.lastViewportRect_ = null; | ||
|
|
||
| /** @private {./layout-rect.LayoutRectDef|undefined} */ | ||
| this.opt_lastIframeRect_ = undefined; |
There was a problem hiding this comment.
Instance/class vars cannot have opt_ prefix. Please remove.
|
LGTM with one request. |
lannka
approved these changes
Mar 13, 2017
| @@ -227,11 +234,22 @@ export class IntersectionObserverPolyfill { | |||
| } | |||
| } | |||
|
|
|||
| // push new observed element | |||
| this.observeEntries_.push({ | |||
| const newEntry = { | |||
There was a problem hiding this comment.
as discussed, please avoid overloading the name entry here. Can be called state instead.
jridgewell
reviewed
Mar 14, 2017
| @@ -300,6 +300,7 @@ export class Visibility { | |||
| onIntersectionChanges, {threshold: DEFAULT_THRESHOLD}); | |||
| //TODO: eventually this is go into the proposed layoutManager. | |||
| const viewport = viewportForDoc(this.ampdoc); | |||
| this.intersectionObserver_.tick(viewport.getRect()); | |||
There was a problem hiding this comment.
Nit: call ticker instead of duplicating its code.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* store last tick value * fix type check * remove opt- * rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7992