Prototype: Quick, dirty implementation of ad lightboxes #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
suggested changes
Mar 3, 2017
| @@ -0,0 +1,103 @@ | |||
| <!doctype html> | |||
examples/ad-lightbox.amp.html
Outdated
| <html ⚡> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>AMP #0</title> |
| properly under normal circumstances. | ||
| --> | ||
|
|
||
| <amp-ad-banner layout="fill"> |
There was a problem hiding this comment.
corresponding <script async custom-element="amp-app-banner" src="https://cdn.ampproject.org/v0/amp-app-banner-0.1.js"></script> is not there
There was a problem hiding this comment.
amp-ad-banner is unimplemented, so it's not needed. The document is not supposed to validate :)
| // fallback. | ||
| const iframeDoc = iframe.contentDocument; | ||
| const iframeBody = iframeDoc.body; | ||
| const adBannerRoot = |
There was a problem hiding this comment.
If this has to be a direct child, use childElementByTag from dom.js
| return; | ||
| } | ||
|
|
||
| if (!isExperimentOn(this.getAmpDoc().win, A4A_PROTOTYPE_EXPERIMENT)) { |
There was a problem hiding this comment.
move this up before the isInMainDocument to make the experiment completely side-effect free.
| return; | ||
| } | ||
|
|
||
| if (!isExperimentOn(this.getAmpDoc().win, A4A_PROTOTYPE_EXPERIMENT)) { |
aghassemi
approved these changes
Mar 3, 2017
kmh287
pushed a commit
to kmh287/amphtml
that referenced
this pull request
Mar 13, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not production ready.
This PR corresponds to an in-progress prototype. Using an
amp-lightboxin an ad will not pass validation and will not function properly under normal circumstances.Guarded under
amp-lightbox-a4a-protoexperiment./cc @jasti
Future work
amp-lightboxmodule.amp-ad-bannerextension (design pending).