Ensure that critical vsync tasks run when rAF is disabled. #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a backup timer for non-animation vsync tasks. This ensures that non-animation tasks still eventually (timer at 2.5X normal rAF time) execute when we somehow failed to detect that we aren't visible. Fixes ampproject#7589
dvoytenko
suggested changes
Feb 17, 2017
| * we continue to get work done. | ||
| * @const {!Pass} | ||
| */ | ||
| this.backupPass_ = new Pass(this.win, this.boundRunScheduledTasks_, |
There was a problem hiding this comment.
I think we should check in this pass when was the last rAF (or queue run) time and only proceed with "force" if this was more than X. Otherwise, we risk constantly interrupting the existing rAF queue. Or do you hope that give .5 we'd mostly find this pass empty?
There was a problem hiding this comment.
We always schedule this and an rAF and cancel the pass when the rAF runs. Under normal rAF operation I do not see how this could ever not be cancelled.
|
Friendly ping. |
dvoytenko
approved these changes
Feb 21, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…t#7639) Add a backup timer for non-animation vsync tasks. This ensures that non-animation tasks still eventually (timer at 2.5X normal rAF time) execute when we somehow failed to detect that we aren't visible. Fixes ampproject#7589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a backup timer for non-animation vsync tasks. This ensures that non-animation tasks still eventually (timer at 2.5X normal rAF time) execute when we somehow failed to detect that we aren't visible.
Fixes #7589