Update to crystal 0.25.0

[bcardiff]

This PR updates to upcoming breaking changes in crystal 0.25.0
Note that this also depends on the following PR been available as a formal release to update the shards.yml

• Upgrade to Crystal 0.25.0 JSON::Any API liquid.cr#32
• Crystal/v0.25.0 mosop/teeplate#12
• Support upcoming Crystal 0.25.0 crystal-ameba/ameba#57

Fixes #847

[drujensen]

@bcardiff Any idea when the docker image will be created for 0.25.0?

https://hub.docker.com/r/crystallang/crystal/tags/

[robacarp]

@bcardiff thank you for doing this, and especially for documenting the needed changes that are prerequisites

[bcardiff]

@drujensen Ideally during next week the former release should be made. If you need, you can use the crystallang/crystal:nightly docker image.

[ilovezfs]

In Homebrew, I've shipped crystal-lang 0.25.0, which has broken the amber formula. It would be great if we could unbreak that as soon as possible.

[faustinoaq]

@ilovezfs Yeah, no problem, I'm already fixing dependencies, we should be ready on next days 👍

[faustinoaq]

@bcardiff I tried to update dependencies, although seems lib/pg (https://github.com/will/crystal-pg) also needs to fix breaking-changes 😅

in lib/pg/src/pg/decoder.cr:4: undefined constant JSON::Type

Ref: https://travis-ci.org/amberframework/amber/jobs/392749736#L716

/cc @will

[will]

pg v0.15.0 was released just now and should fix this

[faustinoaq]

@will Thank you!

I already sent a PR to Granite (1), Crecto (2), and Jennifer (3) repositories

(1) amberframework/granite#228
(2) Crecto/crecto#165
(3) imdrasil/jennifer.cr#143

[faustinoaq]

Oh, seems liquid also need some updates to fix breaking changes 😅

^^ amberframework/liquid.cr#33

[ilovezfs]

I guess CI needs to be retriggered now that liquid.cr was fixed?

[faustinoaq]

Hi, liquid.cr is fine 👍

Now we're getting errors with amber router /cc @robacarp

in spec/amber/router/cookies_spec.cr:27: undefined method 'rfc1123_date' for HTTP:Module

Ref: https://travis-ci.org/amberframework/amber/jobs/393041252#L680

[felixbuenemann]

@faustinoaq I think crystal 0.25.0 lacks direct support for rfc1123, only rcf2822 is exposed.

You can get it by implementing your own formatter function:

def rfc1123_date(time)
  String.build do |io|
    formatter = Time::Format::Formatter.new(time.to_utc, io)
    formatter.rfc_2822(true, true)
    io
  end
end

time = Time.utc(2017, 6, 7, 9)

puts time.to_rfc2822
=> "Wed, 7 Jun 2017 09:00:00 +0000"

puts rfc1123_date(time)
=> "Wed, 07 Jun 2017 09:00:00 GMT"

That's probably an oversight of crystal-lang/crystal#5123.

[bcardiff]

Please check https://crystal-lang.org/api/0.25.0/HTTP.html#parse_time%28time_str%3AString%29%3ATime%3F-class-method

[felixbuenemann]

@bcardiff Thanks, I missed that. I think you meant to link to HTTP.format_time(time):

https://crystal-lang.org/api/0.25.0/HTTP.html#format_time%28time%3ATime%29%3AString-class-method

So replacing HTTP.rfc1123_date with HTTP.format_time should work.

[ilovezfs]

@faustinoaq what's the status here?

[robacarp]

@ilovezfs #857 is the pull addressing this issue.

Unfortunately we're in a dependency-bitrot hell.

[felixbuenemann]

@robacarp Why was this issue closed if #857 is still open?

[robacarp]

@felixbuenemann this isn't an issue, it's a pull request which has been replaced.

[felixbuenemann]

Oh my, sorry for the confusion!