Support upcoming Crystal 0.25.0#57
Merged
Merged
Conversation
The changes are compatible with crystal 0.24.2
Member
|
@bcardiff oh, thanks a lot. I'm ok with a cast here and don't want to change all structs to classes. Honestly, I expected more incompatibilities with |
This was referenced May 28, 2018
4 tasks
|
@veelenga Since crystal 0.25.0 is about to be released it would be great to have a new release tagged which includes these fixes. |
Member
|
Thanks @felixbuenemann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are compatible with crystal 0.24.2
There are changes in the JSON::Any API and due to some internal changes the Rule::Base module either need to be transformed to a class, or the cast introduced in the PR is needed.