Skip to content

Crystal/v0.25.0#12

Merged
mosop merged 2 commits into
mosop:masterfrom
bcardiff:crystal/v0.25.0
Jun 7, 2018
Merged

Crystal/v0.25.0#12
mosop merged 2 commits into
mosop:masterfrom
bcardiff:crystal/v0.25.0

Conversation

@bcardiff
Copy link
Copy Markdown
Contributor

This PR updates to future breaking changes in crystal 0.25
This includes the #9 which are not merged.

cc: @paulcsmith , @faustinoaq both amber and lucky use teeplate. Lucky uses currently my branch fork and amber has forked the repo inside the organization. I am not sure if @mosop is still interested in maintaining this repo, but seems there is interest in it from both framworks. Maybe it can be moved/forked in a common place like crystal-community org.

Pending: update have_files version
Use new File::Permissions and File.info
@paulcsmith
Copy link
Copy Markdown

Thanks for the ping! Teeplate is a wonderful package and I'd love to see it continue to be maintained somewhere. I have too many shards already to help out, but maybe Amber team or someone else in the Crystal community would like to maintain it?

@faustinoaq
Copy link
Copy Markdown

Amber team or someone else in the Crystal community would like to maintain it?

I think would be nice to put this in crystal-community, @veelenga @mosop WDYT?

Or maybe Amber can maintain it @elorest @drujensen @eliasjpr @robacarp WDYT?

@robacarp
Copy link
Copy Markdown

robacarp commented Jun 6, 2018

My preference would be for it to live under crystal-community

@drujensen
Copy link
Copy Markdown
Contributor

I vote for crystal-community as well

@veelenga
Copy link
Copy Markdown

veelenga commented Jun 6, 2018

Let me know and I will grant @mosop rights to move the repo.

Just for the notice: crystal-community usually doesn't evolve the project very much. I've seen people review/merge PRs, prepare releases but don't create new features or work on the issues. If you want the project to grow, you still need to find a maintainer.

@elorest
Copy link
Copy Markdown

elorest commented Jun 7, 2018

Amber is currently using it. I doubt that we'll change much but we at least
have an incentive to keep it working.

@robacarp
Copy link
Copy Markdown

robacarp commented Jun 7, 2018

Yeah, I don't see this one being abandoned, I just don't want the Amber to become the only place where code lives. I'm fine coordinating work on it, helping to steward the project, whatever, I just see a trend in a lot of shards that Amber is built on suffering bitrot and abandonment and simply getting absorbed by Amber. I'd rather not have Amber become the organization that eats projects.

@mosop
Copy link
Copy Markdown
Owner

mosop commented Jun 7, 2018

Hi. Crystal can't run on my macOS now! Why is travis failed?

By the way, how about to create a dedicated organization for this library? And I can easily give rights to you contributors.

@mosop mosop self-requested a review June 7, 2018 09:55
@mosop mosop merged commit b55888a into mosop:master Jun 7, 2018
@mosop
Copy link
Copy Markdown
Owner

mosop commented Jun 7, 2018

Finally fixed! Use v0.6.1 for the new Crystal 0.25, and v0.5.0 for 0.24.2. Thank you all!

@paulcsmith
Copy link
Copy Markdown

Thanks @mosop! This library has been incredibly helpful on Lucky. I really appreciate all the work you've done :)

@drujensen
Copy link
Copy Markdown
Contributor

@mosop This library has been incredibly helpful to Amber as well. We all really appreciate the work you have done! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants