Skip to content

[Shard] [Breaking Change] Update Teeplate Shard to 0.6.1#854

Closed
eliasjpr wants to merge 1 commit into
masterfrom
ep/upgrade-teeplate
Closed

[Shard] [Breaking Change] Update Teeplate Shard to 0.6.1#854
eliasjpr wants to merge 1 commit into
masterfrom
ep/upgrade-teeplate

Conversation

@eliasjpr
Copy link
Copy Markdown
Contributor

Issue: #853

Changes to crystal requires teeplate to be upgraded

Description of the Change

Currently specs are failing because teeplate shard is Out of Date and is causing the following error
lib/teeplate/src/lib/file_tree/macros/directory.cr:33: undefined method 'stat' for File:Class

Benefits

  • Updates to latest Teeplate shard version to correct the issue.

Possible Drawbacks

  • Apps running on older crystal version 0.25.0 might run into an issue.

Issue: #853

Changes to crystal requires teeplate to be upgraded
@faustinoaq
Copy link
Copy Markdown
Contributor

This is already fixed on #826

@eliasjpr
Copy link
Copy Markdown
Contributor Author

eliasjpr commented Jun 16, 2018

Lets merge #826. What are we waiting for?

@eliasjpr
Copy link
Copy Markdown
Contributor Author

Closing this in favor of #826 and #857

@eliasjpr eliasjpr closed this Jun 16, 2018
@faustinoaq faustinoaq deleted the ep/upgrade-teeplate branch June 16, 2018 16:27
@faustinoaq
Copy link
Copy Markdown
Contributor

Lets merge #826. What are we waiting for?

@eliasjpr I think specs should pass first 😅

BTW, WDYT about including crecto/ecr build specs as well?, please see: #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants