Update to Crystal/0.25.0

[robacarp]

This is an internal branch copy of the branch @bcardiff opened in #826

[robacarp]

This is pretty close.

I've disabled automatic json parsing of json requests for now, I think that will need to be revisited and might even not be worth it for the framework to do.

A crystal spec produces this output, from build_spec:

Failures:

  1) building a generated app generates a binary
     Failure/Error: File.exists?("bin/#{TEST_APP_NAME}").should be_true

       Expected: true
            got: false

     # /Users/robert/Documents/repositories/amberframework/amber/spec/build_spec.cr:45

  2) building a generated app crystal spec can be executed
     Failure/Error: spec_result.should contain "Finished in"

       Expected:   ""
       to include: "Finished in"

     # /Users/robert/Documents/repositories/amberframework/amber/spec/build_spec.cr:55

Finished in 19.56 seconds
106 examples, 2 failures, 0 errors, 0 pending

Failed examples:

crystal spec /Users/robert/Documents/repositories/amberframework/amber/spec/build_spec.cr:44 # building a generated app generates a binary
crystal spec /Users/robert/Documents/repositories/amberframework/amber/spec/build_spec.cr:54 # building a generated app crystal spec can be executed

It seems like there are a few places in generated apps which need to be updated.

[robacarp]

Status:

• JSON params parse
• Amber compiles
• Specs pass
  • Build Spec passes
• Generated app compiles
• Dependent shards are all up to date

Shard Hacks Needing Resolving:

• Citrine-i18n -> Techmagistar/i18n dependency chain needs fixed. Pull request Currently pointing to a fork kindly provided by @mamantoha
  • Citrine-i18n needs update PR, merge and release
• Garnet-Spec -> ysbaddaden/selenium-webdriver-crystal dependency chain needs fixed. Pull request Currently pointing to a fork kindly provided by @paulcsmith
  • Garnet-Spec needs update PR, merge and release
• Amber Router needs PR merge and release, Pull request
• Granite needs PR merge and release, Pull request

[faustinoaq]

Travis spec are failing due to a dependency issue:

Outdated shard.lock (wrong resolver). Please run shards update instead.

We had a similar issue here: #814 (comment)

Dependency issues fixed (wrong citrine tag on shard.yml)

[faustinoaq]

@robacarp Awesome, Thank you! 😄

[ilovezfs]

Hurray! @faustinoaq can we get a new tag please? 🙏

[faustinoaq]

can we get a new tag please

@ilovezfs Amber team is already working on that 👍

We're trying to find critical bugs and fix them before a new release 😉