Conversation
To use the PF/EmptyStateHeader component and PF/EmptyState#variant property. Based on changes made by https://github.com/patternfly/pf-codemods.
To stop using `isSmall` and `isLarge` props and use `size` instead. Changes made by https://github.com/patternfly/pf-codemods
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
To be aligned with the change made to adapt PF/TextInput#onChange prop
PF/TableComposable has been renamed to PF/Table. Related to * patternfly/patternfly-react#8005 * patternfly/patternfly-react#8892 Based on the changes proposed by https://github.com/patternfly/pf-codemods
Formerly named as #disable. See patternfly/patternfly-react#8861 Change made by https://github.com/patternfly/pf-codemods/
To set the proper value after PatternFly 5 added the event as first arg for these callback props. See patternfly/patternfly-react#8955 and patternfly/patternfly-react#8955 Commit based on changes made by https://github.com/patternfly/pf-codemods/
PF/ToolbarContent#alignment prop has been removed and the former PF/ToolbarItem#alignment renamed to #align. See patternfly/patternfly-react#8563 Changes made by https://github.com/patternfly/pf-codemods
Because of the change done for PatternFly 5 at patternfly/patternfly-react#9074 Made by https://github.com/patternfly/pf-codemods
After its default value changed in the PatternFly 5. See patternfly/patternfly-react#8183 Change made by https://github.com/patternfly/pf-codemods
As first step for moving to the new PF5/Dropdown component. See patternfly/patternfly-react#8835 and patternfly/patternfly-react#8868 Changes made by https://github.com/patternfly/pf-codemods
Instead, the text is now rendered by a new Agama/FormValidationError helper component that internally makes use of PF/FormHelperText and PF/HelperText for wrapping it. It fixes the `helperTextInvalid prop for FormGroup has been removed` error thrown by https://github.com/patternfly/pf-codemods. More info: - patternfly/patternfly-react#8810 - https://www.patternfly.org/components/forms/form#examples
For fixing the `validated prop for FormGroup has been removed` error thrown by https://github.com/patternfly/pf-codemods during migration to PatternFly 5. See patternfly/patternfly-react#8810
Use the new PF/Dropdown and PF/MenuToggle instead. Related to patternfly/patternfly-react#8835 and others.
By running `npx @patternfly/class-name-updater --fix src` See https://github.com/patternfly/pf-codemods/blob/main/packages/class-name-updater/README.md
For making the icon looks at it was previously with PatternFly v4. Commit also adds space between paragrahps and use the PF/EmptyStateFooter when needed.
By overriding the default PatternFly styles
For fetching the value from second argument. The first one is the event that trigered the change. Related to commit a6282f6
Sadly, the ActionsRow menu does not have aria-label anymore.
By running `npm update --lockfile-version 2`
dgdavid
force-pushed
the
patternfly-v5
branch
from
779210d to
12dc11f
Compare
Because it became a dummy wrapper after the changes introduced to the Dropdown comonent by PatternFly. The only thing that might make some sense to extract (from Agama/WifiNetworkMenu) is the custom toggler if we end up using it in more places.
Because missing event on the password#onChange callback
imobachgs
approved these changes
Oct 2, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Thanks! I have tried and it seems to work quite well.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
joseivanlopez
approved these changes
Oct 3, 2023
Merged
dgdavid
added a commit
that referenced
this pull request
Nov 17, 2023
[web] Fix broken storage links During [migration to PF5](#759), specifically when [moving to the new PF/Dropdown](2edc4e2#diff-88232d7f99420122a9e8c24ae183bcf9a9b98451cbb5db44dea461a2d5ed6727), a few options were unintentionally broken when their `href` prop were not properly renamed to `to`. This [makes the PF/MenuItem to use a `<button>` instead of `<a>`](https://github.com/patternfly/patternfly-react/blob/7d2fd2678f993459f67a04d173a8d16c16ef50a3/packages/react-core/src/components/Menu/MenuItem.tsx#L139) inside an `<li>` when building the menu item, assigning the `href` HTML attribute to the latest, which has no effect at all. As a result, users cannot navigate to these options through the UI, as it was the case in https://bugzilla.suse.com/show_bug.cgi?id=1217281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PatternFly React has released its 5th version back in 27th July 2023. It comes with a lot of improvements and a bunch of breaking changes.
Agama it's young enough to be stuck in PatternFly v4.
Solution
Move to PatternFly 5 by following the upgrade guide and checking that everything work and look as expected.
Testing
Note for reviewers
Please, deploy the branch locally and test the UI from the end user perspective as part of the review. Thank you