feat(TextInput): swapped onChange params#9064
Merged
nicolethoen merged 2 commits intopatternfly:v5from May 9, 2023
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9064.surge.sh A11y report: https://patternfly-react-pr-9064-a11y.surge.sh |
nicolethoen
approved these changes
May 7, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
I even did my own pass through the code do double check I couldn't fine any more instances of TextInput with an onChange handler. Didn't find anything else.
thatblindgeye
approved these changes
May 9, 2023
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 11, 2023
Since the #onChange params were swapped at patternfly/patternfly-react#9064 Based on changes proposed by https://github.com/patternfly/pf-codemods/
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 11, 2023
To be aligned with the change made in at patternfly/patternfly-react#9064
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Since the #onChange params were swapped at patternfly/patternfly-react#9064 Based on changes proposed by https://github.com/patternfly/pf-codemods/
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
To be aligned with the change made in at patternfly/patternfly-react#9064
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 14, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9062
Additional issues: