fix(Table): rename TdSelectType 'disable' prop to 'isDisabled'#8861
Merged
tlabaj merged 2 commits intopatternfly:v5from Apr 7, 2023
Merged
fix(Table): rename TdSelectType 'disable' prop to 'isDisabled'#8861tlabaj merged 2 commits intopatternfly:v5from
tlabaj merged 2 commits intopatternfly:v5from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-8861.surge.sh A11y report: https://patternfly-react-pr-8861-a11y.surge.sh |
nicolethoen
reviewed
Mar 24, 2023
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
LGTM, needs a rebase
adamviktora
force-pushed
the
table-update-TdSelectType
branch
from
b80e5c2 to
a3fd63a
Compare
adamviktora
commented
Mar 27, 2023
Contributor
Author
There was a problem hiding this comment.
@nicolethoen I just found out there is another prop (in TdActionsType), which should probably also be named isDisabled can I create another issue for that? or is it fine to leave it as it is?
Contributor
There was a problem hiding this comment.
You should make another issue for it and send it over to @tlabaj so she can decide if it's something we should do before the v5 release.
tlabaj
approved these changes
Mar 29, 2023
nicolethoen
approved these changes
Mar 31, 2023
kmcfaul
approved these changes
Apr 5, 2023
adamviktora
force-pushed
the
table-update-TdSelectType
branch
from
a3fd63a to
8ed3ab4
Compare
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Formerly named as #disable. See patternfly/patternfly-react#8861 Change made by https://github.com/patternfly/pf-codemods/
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Formerly named as #disable. See patternfly/patternfly-react#8861 Change made by https://github.com/patternfly/pf-codemods/
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 14, 2023
Formerly named as #disable. See patternfly/patternfly-react#8861 Change made by https://github.com/patternfly/pf-codemods/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8419
Additional issues:
codemod issue follows: patternfly/pf-codemods#347