Conversation
We've detected few wrong storage menu items where the `href` attribute is assigned to the `li` HTML component instead to a MISSING `a` element. The root of the problem it's in the props passed to PF/MenuItem through Agama/Storage/ProposalPageOptions --> Agama/PageOptions.Option -> PF/DropdownItem. We are sending an `href` instead of `to` which makes PF/MenuItem deliver a <li href='..'> holding a <button> instead of a <li> holding a <a href='...'> See https://github.com/patternfly/patternfly-react/blob/7d2fd2678f993459f67a04d173a8d16c16ef50a3/packages/react-core/src/components/Menu/MenuItem.tsx#L139 This was broken during the migration to PF5, specifically when moving to the new PF/Dropdown where these `href` props were overlooked and not renamed to `to`. See 2edc4e2#diff-88232d7f99420122a9e8c24ae183bcf9a9b98451cbb5db44dea461a2d5ed6727 So, this change makes the test more robust by checking tha the "menuitem" element has the expected "href". Subsequent commit will fix the problem.
By using the right prop for setting the link href attribute.
imobachgs
approved these changes
Nov 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During migration to PF5, specifically when moving to the new PF/Dropdown, a few options were unintentionally broken when their
hrefprop were not properly renamed toto.This makes the PF/MenuItem to use a
<button>instead of<a>inside an<li>when building the menu item, assigning thehrefHTML attribute to the latest, which has no effect at all.As a result, users cannot navigate to these options through the UI, as it was the case in https://bugzilla.suse.com/show_bug.cgi?id=1217281
Solution
Fix the issue by using the right prop and improve a bit the unit test.
Testing