Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-8810.surge.sh A11y report: https://patternfly-react-pr-8810-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Mix of React/CSS comments below.
packages/react-core/src/components/FileUpload/examples/FileUploadTextWithRestrictions.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/Form/examples/FormHorizontalHelper.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/TextArea/examples/TextAreaValidated.tsx
Outdated
Show resolved
Hide resolved
kmcfaul
force-pushed
the
formgroup-helper
branch
from
7db9ed4 to
dbef559
Compare
Contributor
|
Looks like there is a duplicate-id-aria a11y violation on the Form pages. |
thatblindgeye
approved these changes
Mar 28, 2023
wise-king-sullyman
approved these changes
Mar 31, 2023
srambach
approved these changes
Apr 5, 2023
Member
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
Looks ok to me. I see a slight spacing difference, but that seems to be a difference in core vs. React helper text. I'll put in an issue about that.
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 13, 2023
Instead, the text is now rendered by a new Agama/FormValidationError helper component that internally makes use of PF/FormHelperText and PF/HelperText for wrapping it. It fixes the `helperTextInvalid prop for FormGroup has been removed` error thrown by https://github.com/patternfly/pf-codemods. More info: - patternfly/patternfly-react#8810 - https://www.patternfly.org/components/forms/form#examples
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 14, 2023
Instead, the text is now rendered by a new Agama/FormValidationError helper component that internally makes use of PF/FormHelperText and PF/HelperText for wrapping it. It fixes the `helperTextInvalid prop for FormGroup has been removed` error thrown by https://github.com/patternfly/pf-codemods. More info: - patternfly/patternfly-react#8810 - https://www.patternfly.org/components/forms/form#examples
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 14, 2023
For fixing the `validated prop for FormGroup has been removed` error thrown by https://github.com/patternfly/pf-codemods during migration to PatternFly 5. See patternfly/patternfly-react#8810
bastian-src
pushed a commit
to ATIX-AG/foreman_resource_quota
that referenced
this pull request
Mar 19, 2025
* Collapse CardActions directly into CardHeader https://v5-archive.patternfly.org/get-started/release-highlights/#card * Apply new css variable naming schema https://v5-archive.patternfly.org/get-started/upgrade/#review-and-update-variable-and-class-names * Rely for now on deprecated Dropdown component https://v5-archive.patternfly.org/get-started/upgrade#upgrade-deprecated-components * Apply new onChange and onToggle parameter requirements (search onChange) https://v5-archive.patternfly.org/get-started/upgrade/release-notes * Apply new react-icons import paths https://github.com/patternfly/patternfly-react/blob/v5/packages/react-icons/README.md * Apply new HelperText and HelperTextItem usage in FormGroup patternfly/patternfly-react#8810 * Fix EditableTextInput by encapsulating CSS changes in a container-class
bastian-src
pushed a commit
to ATIX-AG/foreman_resource_quota
that referenced
this pull request
Mar 19, 2025
* Collapse CardActions directly into CardHeader https://v5-archive.patternfly.org/get-started/release-highlights/#card * Apply new css variable naming schema https://v5-archive.patternfly.org/get-started/upgrade/#review-and-update-variable-and-class-names * Rely for now on deprecated Dropdown component https://v5-archive.patternfly.org/get-started/upgrade#upgrade-deprecated-components * Apply new onChange and onToggle parameter requirements (search onChange) https://v5-archive.patternfly.org/get-started/upgrade/release-notes * Apply new HelperText and HelperTextItem usage in FormGroup patternfly/patternfly-react#8810 * Fix EditableTextInput by encapsulating CSS changes in a container-class
bastian-src
pushed a commit
to ATIX-AG/foreman_resource_quota
that referenced
this pull request
Mar 19, 2025
* Collapse CardActions directly into CardHeader https://v5-archive.patternfly.org/get-started/release-highlights/#card * Apply new css variable naming schema https://v5-archive.patternfly.org/get-started/upgrade/#review-and-update-variable-and-class-names * Rely for now on deprecated Dropdown component https://v5-archive.patternfly.org/get-started/upgrade#upgrade-deprecated-components * Apply new onChange and onToggle parameter requirements (search onChange) https://v5-archive.patternfly.org/get-started/upgrade/release-notes * Apply new HelperText and HelperTextItem usage in FormGroup patternfly/patternfly-react#8810 * Fix EditableTextInput by encapsulating CSS changes in a container-class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #4552
Updated
FormGroupto not use its own implementation of helper text. Since a lot of the internal implementation is covered byHelperText, the props surrounding helper text are no longer needed andHelperTextcan be passed as part of theFormGroupchildren directly.FormHelperTextmay not be needed anymore either, but leaving that in for now.