(backend bug): Added missed VLAN device type conversion from NetworkManager #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
changed the title
Merged
imobachgs
added a commit
that referenced
this pull request
Jul 21, 2025
Prepare to release Agama 17: * #2459 * #2492 * #2526 * #2527 * #2528 * #2529 * #2530 * #2531 * #2532 * #2533 * #2534 * #2536 * #2537 * #2538 * #2540 * #2541 * #2542 * #2543 * #2544 * #2545 * #2546 * #2547 * #2548 * #2550 * #2551 * #2553 * #2554 * #2555 * #2556 * #2557 * #2558 * #2559 * #2560 * #2561 * #2562 * #2563 * #2564 * #2565 * #2566 * #2567 * #2568 * #2570 * #2571 * #2572 * #2575 * #2576 * #2577 * #2579 * #2580 * #2583 * #2584 * #2585 * #2586 * #2587 * #2588 * #2589 * #2591
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 23, 2025
https://build.opensuse.org/request/show/1295145 by user mvidner + anag_factory - fix .changes errors reported by obs-service-source_validator (gh#agama-project/agama#2593) - Version 17 - Add support for an inst.script that allows to run an arbitrary script (bsc#1246702, gh#agama-project/agama#2589). - Ensure software cache is updated even if part of its config cause error (gh#agama-project/agama#2585) - Fix device type detection when reading a VLAN connection (gh#agama-project/agama#2586). - Add support to configure VLANs through the CLI or HTTP API (gh#agama-project/agama#2580). - Adjust the information included in the logs (gh#agama-project/agama#2575). - Fix crash when an Agama profile contains only the zfcp section by providing better error report when product selection have to be done before or in the same profile (bsc#1246601) - When search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VLAN connections are skipped from reading because the DeviceType is not identified properly.
Solution
Added the proper conversion from NmDeviceType to DeviceType missed by (#918 & #2580).
Test
Tested manually checking the the configuration is read and the connection details is displayed properly in the UI.