fix(web): do not scroll to top when selecting sofware #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By keeping selected product in a different cache than software config. It somehow undo dc5ea33 Co-Authored-By: Imobach González Sosa <[email protected]>
imobachgs
approved these changes
Jul 4, 2025
Prevents outdated data from being shown in the UI by clearing the cache of the previously selected product before probing the system. This ensures the interface reflects the correct, current product state.
imobachgs
approved these changes
Jul 7, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Jul 21, 2025
Prepare to release Agama 17: * #2459 * #2492 * #2526 * #2527 * #2528 * #2529 * #2530 * #2531 * #2532 * #2533 * #2534 * #2536 * #2537 * #2538 * #2540 * #2541 * #2542 * #2543 * #2544 * #2545 * #2546 * #2547 * #2548 * #2550 * #2551 * #2553 * #2554 * #2555 * #2556 * #2557 * #2558 * #2559 * #2560 * #2561 * #2562 * #2563 * #2564 * #2565 * #2566 * #2567 * #2568 * #2570 * #2571 * #2572 * #2575 * #2576 * #2577 * #2579 * #2580 * #2583 * #2584 * #2585 * #2586 * #2587 * #2588 * #2589 * #2591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recent changes to cache handling in the web interface caused the software selection page to scroll to the top whenever the user changes their selection. This behavior degrades the user experience.
Solution
Partially revert dc5ea33 to separate the selected product's cache from the software/config cache. This prevents the src/App wrapper component from being re-rendered when the configuration updates due to software changes, preserving the scroll position.
Testing
Manually tested: used the generated ISO at https://download.opensuse.org/repositories/systemsmanagement:/Agama:/Devel/images/iso/ (link may no longer work) to verify that changing the software selection no longer causes the page to scroll to the top.