fix(storage): keep storage config after registration #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Service status: only #start_up needs to manage the service status. The rest of methods are always called from D-Bus methods, which already manage the service status. - Reprobing: hack for forcing reprobing is not needed anymore.
dgdavid
reviewed
Jul 7, 2025
| const probe = () => post("/api/manager/probe_sync"); | ||
|
|
||
| /** | ||
| * Triggers a synchronous reprobing process. |
Contributor
There was a problem hiding this comment.
Jus a question, does Agama server provide their async counterparts? Asking because I also see in manager "probe_sync" and "probe".
Contributor
Author
There was a problem hiding this comment.
No, an async version is not needed yet.
Contributor
Author
There was a problem hiding this comment.
Anyway, all this about sync/async probing/reprobing is something to revisit. For now, just following the current approach.
Contributor
There was a problem hiding this comment.
Anyway, all this about sync/async probing/reprobing is something to revisit.
Great then.
Thank you
dgdavid
approved these changes
Jul 7, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
As per my limited Rust knowledge, LGTM
| pub async fn reprobe(&self) -> Result<(), ManagerHTTPClientError> { | ||
| // BaseHTTPClient did not anticipate POST without request body | ||
| // so we pass () which is rendered as `null` | ||
| Ok(self.client.post_void("/manager/reprobe_sync", &()).await?) |
Merged
imobachgs
added a commit
that referenced
this pull request
Jul 21, 2025
Prepare to release Agama 17: * #2459 * #2492 * #2526 * #2527 * #2528 * #2529 * #2530 * #2531 * #2532 * #2533 * #2534 * #2536 * #2537 * #2538 * #2540 * #2541 * #2542 * #2543 * #2544 * #2545 * #2546 * #2547 * #2548 * #2550 * #2551 * #2553 * #2554 * #2555 * #2556 * #2557 * #2558 * #2559 * #2560 * #2561 * #2562 * #2563 * #2564 * #2565 * #2566 * #2567 * #2568 * #2570 * #2571 * #2572 * #2575 * #2576 * #2577 * #2579 * #2580 * #2583 * #2584 * #2585 * #2586 * #2587 * #2588 * #2589 * #2591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The storage config is lost after registering a product.
https://bugzilla.suse.com/show_bug.cgi?id=1245400
Solution
Reprobe the system instead of a complete probing.
Note: in the future, a better solution will be implemented to avoid delegating the reprobing call to the clients, see https://gist.github.com/joseivanlopez/8d8103ffd4a8e5539046cb6e134be05f.