fix: better handling of missing license translations #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the license is not avaialable in the user's language, display a warning (and show the license in english, as it comes from the backend).
imobachgs
force-pushed
the
licenses-translations
branch
from
01849ac to
6029fae
Compare
dgdavid
approved these changes
Jul 16, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
TL;DR: LGTM 👍
As @shundhammer wrote in the bug report,
That additional combo box with the license translations was always quite weird; yet another language selection.
It was there because of reasons, but it felt indeed always weird. Now that stuff changed around the interface language selection and users can do it from the almost always available language selector at the top, this is hands-down a great step forward... for such a particular dialog.
Thanks!
dgdavid
requested changes
Jul 16, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Arg! We forgot the tests 🙄
dgdavid
approved these changes
Jul 17, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
Jul 21, 2025
Prepare to release Agama 17: * #2459 * #2492 * #2526 * #2527 * #2528 * #2529 * #2530 * #2531 * #2532 * #2533 * #2534 * #2536 * #2537 * #2538 * #2540 * #2541 * #2542 * #2543 * #2544 * #2545 * #2546 * #2547 * #2548 * #2550 * #2551 * #2553 * #2554 * #2555 * #2556 * #2557 * #2558 * #2559 * #2560 * #2561 * #2562 * #2563 * #2564 * #2565 * #2566 * #2567 * #2568 * #2570 * #2571 * #2572 * #2575 * #2576 * #2577 * #2579 * #2580 * #2583 * #2584 * #2585 * #2586 * #2587 * #2588 * #2589 * #2591
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 22, 2025
https://build.opensuse.org/request/show/1294907 by user IGonzalezSosa + anag_factory - Version 17 - Fix extensions layout to reduce excessive gaps on large screens (gh#agama-project/agama#2590). - Fixed crash when registering an extension without registration key (bsc#1246690) - Replaced all usage of generatePath with generateEncodedPath to ensure proper URL encoding of route parameters and prevent issues with special characters (bsc#1246551). - Add button to allow re-probing storage devices. (gh#agama-project/agama#2565) - Display a message when the license is not available in the selected language (bsc#1238364, gh#agama-project/agama#2571). - Allow to use a whole disk or MD RAID without a partition table (gh#agama-project/agama#2559). - Allow specifying the registration server (jsc#AGM-156). - Improve UX around non-persistent connections (bsc#1245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When displaying a product license, Agama allows to select the language to display the license. In general, it offers the same list of languages Agama is translated to. This has a few problems:
Solution
Now the license is directly shown in the same language that Agama is using. No additional language selector. If the translation is missing:
Alternative language
To search for an alternative language, Agama choses the first language in the same "territory". For instance, if you pick "Catalan" ("ca-ES"), Agama uses the langtable data to search for the first language in the same territory, which in this case it is "Spanish" (es).
Testing
Screenshots
The license is translated. No warning and no selector.
The license is not translated to Catalan, but to Spanish. Warn the user.
Fall back to English. Warn the user.
Known problems