Allow to deselect the product defined LSM from the Software selection (bsc#1244431) #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Jul 7, 2025
jreidinger
reviewed
Jul 7, 2025
jreidinger
reviewed
Jul 8, 2025
jreidinger
reviewed
Jul 8, 2025
teclator
changed the title
jreidinger
approved these changes
Jul 9, 2025
imobachgs
added a commit
that referenced
this pull request
Jul 15, 2025
…2560) ## Problem We have been reported that using auto-installation Agama does not honor the list of patterns included in the profile. This behavior is related to the recent feature we introduced to disable SELinux (see #2540). ## Solution Change the approach to select the default LSM only after selecting the product instead of during the "probing" phase. ## Testing - Added a new unit test - Tested manually ## Pre-selecting patterns This PR introduces a mechanism to determine whether a user pattern should be enabled by default: ```yaml user_patterns: - cockpit - name: selinux selected: true - fips - documentation ```
Merged
imobachgs
added a commit
that referenced
this pull request
Jul 21, 2025
Prepare to release Agama 17: * #2459 * #2492 * #2526 * #2527 * #2528 * #2529 * #2530 * #2531 * #2532 * #2533 * #2534 * #2536 * #2537 * #2538 * #2540 * #2541 * #2542 * #2543 * #2544 * #2545 * #2546 * #2547 * #2548 * #2550 * #2551 * #2553 * #2554 * #2555 * #2556 * #2557 * #2558 * #2559 * #2560 * #2561 * #2562 * #2563 * #2564 * #2565 * #2566 * #2567 * #2568 * #2570 * #2571 * #2572 * #2575 * #2576 * #2577 * #2579 * #2580 * #2583 * #2584 * #2585 * #2586 * #2587 * #2588 * #2589 * #2591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently Selinux is selected based on the product LSM definition but although it is possible to deselect it from the Software selection when installing some product it is always installed at the end of the installation.
Solution
When starting the installation the patterns of the default LSM defined in the product definition will be selected like as them were selected by the user allowing to deselect them and to select other LSM patterns if wanted so.
At the end of the installation the selected LSM will be based on the software selection having the default one precedence over the other candidates. The first one which patterns are included in the Software proposal will be configured.
Tests