Skip to content

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jun 18, 2025

Problem

When using an AutoYaST profile, the pre-scripts are executed as part of the initial profile validation (agama config generate). The problem is that those scripts, and its logs, are missing from the /run/agama/scripts directory and hence not copied to the final system.

Solution

The fix consists on copying those files to /run/agama/scripts/autoyast. We are not using the regular /run/agama/scripts/pre because they are executed at a different point.

Testing

  • Added a new unit test
  • Tested manually

@coveralls
Copy link

Coverage Status

coverage: 88.82% (+26.7%) from 62.099%
when pulling 3b897c7 on preserve-ay-pre-scripts
into 35f31ba on master.

@coveralls
Copy link

coveralls commented Jun 18, 2025

Coverage Status

coverage: 62.137% (+0.04%) from 62.099%
when pulling d962020 on preserve-ay-pre-scripts
into 35f31ba on master.

@imobachgs imobachgs force-pushed the preserve-ay-pre-scripts branch from eb83aab to 495d8aa Compare June 18, 2025 07:14
@imobachgs imobachgs marked this pull request as ready for review June 18, 2025 07:19
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 3e05d9b into master Jun 18, 2025
16 checks passed
@imobachgs imobachgs deleted the preserve-ay-pre-scripts branch June 18, 2025 09:37
@imobachgs imobachgs mentioned this pull request Jun 30, 2025
imobachgs added a commit that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants