fix: make sure queries are sync #2479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It was failing most probably because of the suspend API. * Just mock the hooks by now to workaround the problem.
* The installer context does not display the children unless the WebSocket is already connected.
Because it is making the whole stack fail after latest changes with > Uncaught ReferenceError: can't access lexical declaration > '__WEBPACK_DEFAULT_EXPORT__' before initialization Definetely, barrel files have proven to be kind of problematic when application grow. For further reading on the pitfalls of barrel files, see: https://tkdodo.eu/blog/please-stop-using-barrel-files https://laniewski.me/blog/pitfalls-of-barrel-files-in-javascript-modules/
dgdavid
approved these changes
Jun 17, 2025
|
|
||
| // An array of glob patterns indicating a set of files for which coverage information should be collected | ||
| collectCoverageFrom: ["src/**/*.{js,jsx}", "!src/lib/*.js"], | ||
| collectCoverageFrom: ["src/**/*.{js,jsx,ts,tsx}"], |
| (bsc#1243276, gh#agama-project/agama#2479). | ||
| - Properly jump to the progress page when the product is selected | ||
| by a third party (e.g., "agama config load"). | ||
| - Log WebSocket messages in the console with "debug" log level. |
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 30, 2025
Prepare to release Agama 16: * #1868 * #2347 * #2356 * #2373 * #2393 * #2402 * #2404 * #2406 * #2408 * #2409 * #2410 * #2411 * #2412 * #2413 * #2414 * #2415 * #2416 * #2417 * #2418 * #2419 * #2420 * #2421 * #2422 * #2423 * #2424 * #2425 * #2426 * #2427 * #2428 * #2431 * #2433 * #2434 * #2436 * #2437 * #2438 * #2439 * #2440 * #2441 * #2442 * #2443 * #2445 * #2446 * #2450 * #2451 * #2452 * #2453 * #2454 * #2455 * #2456 * #2457 * #2458 * #2460 * #2461 * #2462 * #2463 * #2464 * #2465 * #2466 * #2467 * #2468 * #2469 * #2470 * #2471 * #2472 * #2473 * #2474 * #2475 * #2476 * #2478 * #2479 * #2480 * #2482 * #2483 * #2484 * #2485 * #2487 * #2488 * #2489 * #2490 * #2491 * #2493 * #2494 * #2495 * #2496 * #2497 * #2498 * #2499 * #2502 * #2505 * #2507 * #2509 * #2511 * #2512 * #2513 * #2515 * #2516 * #2517 * #2518 * #2520 * #2523 * #2524 * #2525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Here is a proposal to solve bsc#1243276 and other synchronization problems. It needs to be tested more extensively.
We have detected that the web UI can get into the following scenario:
ProductSelected.As you can see, there is a chance that Agama misses the signal (step 4). If the WebSocket connections happens before (which is the normal case), everything should work.
Solution
Appcomponent until theWebSocketis ready.Appis umounted and it has the chance to clean-up the queries.Tasks