-
Notifications
You must be signed in to change notification settings - Fork 68
fix(web): improve software queries invalidation #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4af1536 to
0e1e012
Compare
dgdavid
approved these changes
Jun 27, 2025
Contributor
dgdavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 30, 2025
Prepare to release Agama 16: * #1868 * #2347 * #2356 * #2373 * #2393 * #2402 * #2404 * #2406 * #2408 * #2409 * #2410 * #2411 * #2412 * #2413 * #2414 * #2415 * #2416 * #2417 * #2418 * #2419 * #2420 * #2421 * #2422 * #2423 * #2424 * #2425 * #2426 * #2427 * #2428 * #2431 * #2433 * #2434 * #2436 * #2437 * #2438 * #2439 * #2440 * #2441 * #2442 * #2443 * #2445 * #2446 * #2450 * #2451 * #2452 * #2453 * #2454 * #2455 * #2456 * #2457 * #2458 * #2460 * #2461 * #2462 * #2463 * #2464 * #2465 * #2466 * #2467 * #2468 * #2469 * #2470 * #2471 * #2472 * #2473 * #2474 * #2475 * #2476 * #2478 * #2479 * #2480 * #2482 * #2483 * #2484 * #2485 * #2487 * #2488 * #2489 * #2490 * #2491 * #2493 * #2494 * #2495 * #2496 * #2497 * #2498 * #2499 * #2502 * #2505 * #2507 * #2509 * #2511 * #2512 * #2513 * #2515 * #2516 * #2517 * #2518 * #2520 * #2523 * #2524 * #2525
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 1, 2025
https://build.opensuse.org/request/show/1289321 by user IGonzalezSosa + anag_factory - Version 16 - Extra usability improvements defining the size of partitions and logical volumes (related to gh#agama-project/agama#2496). - Warn the user about using a weak encryption password (gh#agama-project/agama#2524). - Invalidate all software queries when the selected product changes (gh#agama-project/agama#2517). - Improve usability for defining the size of a partition or logical volume (gh#agama-project/agama#2496). - Warn the user when using a weak user password (bsc#1237480).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The software configuration is handled using two different queries:
software/configandsoftware/product. The invalidation of those queries happen in different places:useProductChangesanduseInstallerStatusChanges.We found this problem while trying to debug bsc#1243276 but we do not think it is going to solve that problem.
Solution
This PR unifies the handling of the configuration. The
software/productis removed in favor ofsoftware/config, and theuseInstallerStatusChangesdoes not invalidate the software queries anymore.Additionally, when the product changes, all software queries are invalidated.
Testing