Skip to content

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jun 27, 2025

Problem

The software configuration is handled using two different queries: software/config and software/product. The invalidation of those queries happen in different places: useProductChanges and useInstallerStatusChanges.

We found this problem while trying to debug bsc#1243276 but we do not think it is going to solve that problem.

Solution

This PR unifies the handling of the configuration. The software/product is removed in favor of software/config, and the useInstallerStatusChanges does not invalidate the software queries anymore.

Additionally, when the product changes, all software queries are invalidated.

Testing

  • Tested manually

@imobachgs imobachgs force-pushed the fix-selected-product-cache branch from 4af1536 to 0e1e012 Compare June 27, 2025 15:31
@coveralls
Copy link

coveralls commented Jun 27, 2025

Coverage Status

coverage: 64.482% (+0.007%) from 64.475%
when pulling d17d27c on fix-selected-product-cache
into 41c66e5 on master.

@imobachgs imobachgs marked this pull request as ready for review June 27, 2025 15:39
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 1594bfe into master Jun 29, 2025
9 checks passed
@imobachgs imobachgs deleted the fix-selected-product-cache branch June 29, 2025 12:10
@imobachgs imobachgs mentioned this pull request Jun 30, 2025
imobachgs added a commit that referenced this pull request Jun 30, 2025
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jul 1, 2025
https://build.opensuse.org/request/show/1289321
by user IGonzalezSosa + anag_factory
- Version 16

- Extra usability improvements defining the size of partitions and
  logical volumes (related to gh#agama-project/agama#2496).

- Warn the user about using a weak encryption password
  (gh#agama-project/agama#2524).

- Invalidate all software queries when the selected product changes
  (gh#agama-project/agama#2517).

- Improve usability for defining the size of a partition or logical
  volume (gh#agama-project/agama#2496).

- Warn the user when using a weak user password (bsc#1237480).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants