Network persistent connections handling RC1 #2431

teclator · 2025-06-02T19:30:24Z

Changes added by #2402 but targeting rc1.

Extends PF/Switch to include a label and description, providing additional context for toggles.

This component renders brief notes or clarifications with an optional icon, using the <strong> HTML element to emphasize the text. It is intended for non-<Alert> annotations that still require emphasis.

This introduces a UI warning that should be shown only when all available network connections are configured for installation use only. Currently, the warning is always rendered; future commits should implement the proper logic to show it conditionally.

Introduce the AllConnectionsStatusAlert component to display a contextual summary of how network connections are configured (installation-only, persistent, or mixed). The alert supports optional bulk actions to adjust all connections and is conditionally rendered based on connection count and mode. It replaces the static warning from the previous commit, but similar to it is always rendered in mixed mode until future commits implement the proper logic to show it conditionally depending on the real connections status.

This adds a toggle allowing users to mark a network connection as either transient (used only during installation) or persistent (available in the installed system). Also includes minor related fixes: - Adjusted flex direction in SwitchEnhanced - Added missing exports in components/core

A tiny bug detected by unit tests added in previous commit.

Introduced by mistake in bdf3b15

Also add missing unit tests for the UI control responsible for toggling the "keep" flag on a connection using this mutation.

Although its "bulk actions" are still pending and not functional at all.

Allows expressions like `if (!isEmpty(variable)) doSomething()` to work when `variable` is a boolean (e.g., `true`). An example use case can be found in `types/network.ts`, which was adapted to use the updated function.

…persisted" This reverts commit 5d8b33d.

Replaced the previous AllConnectionsStatusAlert component with a simpler NoPersistentConnectionsAlert that displays a warning only when all network connections are set to be transient (not persisted in the installed system). Removed unused complexity such as mixed-mode detection and global actions, which may be revisited in future iterations.

Forgotten in de16a48

The nested hash string values are surrounded by quotes when using `.to_string()` but not with `try_into()`.

) ## Problem When a connection is created bind to an interface renamed with the kernel ifname kernel cmdline argument, it could be problematic as the parameter is not kept after the installation. - https://bugzilla.suse.com/show_bug.cgi?id=1241969 - https://bugzilla.suse.com/show_bug.cgi?id=1237327 ## Solution Create a systemd network link file for renaming the interface after the installation ## Testing - *Added unit test for copying the link systemd network link files** - *Tested manually* ![image](https://github.com/user-attachments/assets/834a45ba-7d7c-4f4a-829a-84fb7426965d)

This reverts commit c0d26fe.

imobachgs

We need these fixes in RC1. But I would like to have a closer look when working on the master branch version.

rust/agama-network/src/model.rs

imobachgs · 2025-06-03T15:11:59Z

rust/agama-network/src/model.rs

            ieee_8021x_config: Default::default(),
            autoconnect: true,
            state: Default::default(),
+            keep: true,


master: Should we consider using copy? For me it sounds inconsistent having keep and copy.

what about: persistent ... at the end it is about persist or not to disk using the enum NMSettingsAddConnection2Flags or enum NMSettingsUpdate2Flags

I mean, this is the connection one, so, for me having it a persist or persistent looks better while for the general state it is about copying or not copying the persistent configuration.

rust/agama-network/src/nm/client.rs

rust/agama-network/src/system.rs

rust/agama-server/src/network/web.rs

imobachgs · 2025-06-03T15:29:44Z

rust/agama-server/src/network/web.rs

+    State(state): State<NetworkServiceState>,
+    Path(id): Path<String>,
+) -> Result<impl IntoResponse, NetworkError> {
+    if id == "all" {


master: IMHO there is too much logic in this function.

Prepare to release Agama 16: * #1868 * #2347 * #2356 * #2373 * #2393 * #2402 * #2404 * #2406 * #2408 * #2409 * #2410 * #2411 * #2412 * #2413 * #2414 * #2415 * #2416 * #2417 * #2418 * #2419 * #2420 * #2421 * #2422 * #2423 * #2424 * #2425 * #2426 * #2427 * #2428 * #2431 * #2433 * #2434 * #2436 * #2437 * #2438 * #2439 * #2440 * #2441 * #2442 * #2443 * #2445 * #2446 * #2450 * #2451 * #2452 * #2453 * #2454 * #2455 * #2456 * #2457 * #2458 * #2460 * #2461 * #2462 * #2463 * #2464 * #2465 * #2466 * #2467 * #2468 * #2469 * #2470 * #2471 * #2472 * #2473 * #2474 * #2475 * #2476 * #2478 * #2479 * #2480 * #2482 * #2483 * #2484 * #2485 * #2487 * #2488 * #2489 * #2490 * #2491 * #2493 * #2494 * #2495 * #2496 * #2497 * #2498 * #2499 * #2502 * #2505 * #2507 * #2509 * #2511 * #2512 * #2513 * #2515 * #2516 * #2517 * #2518 * #2520 * #2523 * #2524 * #2525

dgdavid and others added 30 commits June 2, 2025 20:09

feat(web): add SwitchEnhanced with description support

0f8014d

Extends PF/Switch to include a label and description, providing additional context for toggles.

feat(web): add Annotation component for short, emphasized notes

49a0193

This component renders brief notes or clarifications with an optional icon, using the <strong> HTML element to emphasize the text. It is intended for non-<Alert> annotations that still require emphasis.

web: add basic unit tests for network connection details

8016f1e

fix(web): stop rendering gateway6 IP wrongly

d80de6d

A tiny bug detected by unit tests added in previous commit.

web: please linters

adf9263

Added logic to the backend for keeping connections

05080a9

Added logic to the service for copying the connections to be persisted

d3320af

Adapt the UI to really show the connections keep state

21a37f8

Do not apply changes when change keep state

0beef9f

Added the mutation for changing keep state

2f7f083

fix(web): revert not needed code

19cb904

Introduced by mistake in bdf3b15

fix(web): ensure keep/unkeep mutation works as expected

6810e15

Also add missing unit tests for the UI control responsible for toggling the "keep" flag on a connection using this mutation.

fix(web): please ESLint

ed197c0

feat(web): show transient/persistent connection alert on proceed

6570664

Although its "bulk actions" are still pending and not functional at all.

fix(web): make NetworkPage test pass

40a24a0

fix(web): add boolean support to isEmpty function

2eeb59f

Allows expressions like `if (!isEmpty(variable)) doSomething()` to work when `variable` is a boolean (e.g., `true`). An example use case can be found in `types/network.ts`, which was adapted to use the updated function.

fix(backend): Initialize properly the connections to be kept

5b33012

Use update2 and add2 with corresponding keep flags

ecc99bb

Replace the keep_connections logic by flags one

5551b7d

Trace errors when handling not_copy_network file

3a3b3ac

Flags is a property and not part of the settings

d203859

feat(backend): added keep status

ddc2406

Revert "Added logic to the service for copying the connections to be …

c63cdde

…persisted" This reverts commit 5d8b33d.

fix(web): fix outdated mock

3bd9d9e

Forgotten in de16a48

Move connections to persitent instead of copying

b807f17

Only move the generated by nm-initrd-generator

9a2480f

teclator and others added 10 commits June 3, 2025 09:41

Handle correctly controller relationship

b71fa7a

Use a post instead of patch

d0b89ad

Allow to keep and unkeep all the connections

a3b3a7b

Make connections persistent if there is no one

3b63eab

Make network.startup method public

550f0dd

nm/dbus: fix cleanup_dbus_connection for bridge-port

a32d9aa

The nested hash string values are surrounded by quotes when using `.to_string()` but not with `try_into()`.

changes: fix cleanup_dbus_connection for bridge-port

82266bf

Added changelogs

a1b9a99

Please cargo fmt check

5755187

teclator marked this pull request as ready for review June 3, 2025 09:19

teclator added 4 commits June 3, 2025 10:54

Fix manager test.

d83f4e4

Do not filter children connections

c0d26fe

Revert "Do not filter children connections"

ac2cd15

This reverts commit c0d26fe.

Fix controllers unit test

4084fc2

imobachgs approved these changes Jun 3, 2025

View reviewed changes

imobachgs merged commit 8e10aff into rc1 Jun 3, 2025
10 of 11 checks passed

imobachgs deleted the network-persistent-connections-handling-rc1 branch June 3, 2025 15:34

imobachgs mentioned this pull request Jun 30, 2025

Update to release 16 #2521

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Network persistent connections handling RC1 #2431

Network persistent connections handling RC1 #2431

Uh oh!

teclator commented Jun 2, 2025 •

edited

Loading

Uh oh!

imobachgs left a comment

Uh oh!

Uh oh!

imobachgs Jun 3, 2025

Uh oh!

teclator Jun 4, 2025 •

edited

Loading

Uh oh!

teclator Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs Jun 3, 2025

Uh oh!

teclator Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Network persistent connections handling RC1 #2431

Network persistent connections handling RC1 #2431

Uh oh!

Conversation

teclator commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imobachgs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

imobachgs Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

teclator Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teclator Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imobachgs Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

teclator Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

teclator commented Jun 2, 2025 •

edited

Loading

teclator Jun 4, 2025 •

edited

Loading