Skip to content

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jun 4, 2025

Update web dependencies to their latest versions except React and React Router DOM and related ones, since both has published major versions that should be updated in separated PRs with their corresponding migrations after
PatternFly supports React 19.


Following commands has been executed with success,

  • npm run eslint
  • npm run stylelint
  • npm run check-types
  • npm run server
  • npm run build
  • NODE_ENV=production npm run build

Tested manually too using https://download.opensuse.org/repositories/systemsmanagement:/Agama:/branches:/update-deps-20250603/images/iso/agama-installer.x86_64-openSUSE.iso from https://build.opensuse.org/project/show/systemsmanagement:Agama:branches:update-deps-20250603 and performing below actions

  • Select a product
  • Download logs
  • Change a product
  • Change language and keyboard
  • Change hostname
  • Change timezone
  • Edit a network connection
  • Edit the storage proposal (using a LVM)
  • Edit software selection
  • Create first user
  • Create password for root
  • Start the installation

Note for reviewers


Previous updates:

dgdavid added 12 commits June 4, 2025 13:08
It was introduced with the Cockpit infrastructure setup
(d54df81),
but Agama no longer relies on Cockpit or uses this dependency.
This was introduced with the Cockpit infrastructure setup
(d54df81),
but Agama no longer relies on Cockpit or uses this dependency.
This was introduced with the Cockpit infrastructure setup
(d54df81),
but Agama no longer relies on Cockpit or uses this dependency.
Updated the following packages:

 @types/jest                    ^29.5.12  →  ^29.5.14
 @types/webpack-env              ^1.18.5  →   ^1.18.8
 css-loader                       ^7.1.1  →    ^7.1.2
 css-minimizer-webpack-plugin     ^7.0.0  →    ^7.0.2
 eslint-config-prettier          ^10.1.1  →   ^10.1.5
 eslint-webpack-plugin            ^5.0.0  →    ^5.0.1
 fast-sort                        ^3.4.0  →    ^3.4.1
 html-minimizer-webpack-plugin    ^5.0.0  →    ^5.0.2
 jsdoc                            ^4.0.2  →    ^4.0.4
 react-refresh-typescript         ^2.0.9  →   ^2.0.10
 sass-loader                     ^16.0.1  →   ^16.0.5
 stylelint-prettier               ^5.0.0  →    ^5.0.3
 stylelint-webpack-plugin         ^5.0.0  →    ^5.0.1
 terser-webpack-plugin            ^5.3.9  →   ^5.3.14
 ts-loader                        ^9.5.1  →    ^9.5.2
Updated the following packages:

 @babel/core                    ^7.23.3  →   ^7.27.4
 @babel/eslint-parser           ^7.23.3  →   ^7.27.5
 @babel/preset-env              ^7.23.3  →   ^7.27.2
 @babel/preset-react            ^7.23.3  →   ^7.27.1
 @date-fns/tz                    ^1.1.2  →    ^1.2.0
 @tanstack/react-query          ^5.49.2  →   ^5.80.3
 @testing-library/jest-dom       ^6.2.0  →    ^6.6.3
 @testing-library/react         ^16.0.1  →   ^16.3.0
 @testing-library/user-event    ^14.5.1  →   ^14.6.1
 @typescript-eslint/parser       ^8.6.0  →   ^8.33.1
 ajv                            ^8.12.0  →   ^8.17.1
 axios                           ^1.7.3  →    ^1.9.0
 globals                        ^16.0.0  →   ^16.2.0
 ipaddr.js                       ^2.1.0  →    ^2.2.0
 mini-css-extract-plugin         ^2.7.6  →    ^2.9.2
 prettier                        ^3.3.2  →    ^3.5.3
 sass                           ^1.69.5  →   ^1.89.1
 stylelint                      ^16.5.0  →  ^16.20.0
 ts-jest                        ^29.2.2  →   ^29.3.4
 tsconfig-paths-webpack-plugin   ^4.0.0  →    ^4.2.0
 typescript                      ^5.7.2  →    ^5.8.3
 webpack                        ^5.89.0  →   ^5.99.9
 webpack-dev-server              ^5.0.4  →    ^5.2.2
 xbytes                          ^1.8.0  →    ^1.9.1
Because there is "@eslint/js" one that suppose to be the same (?)
Updated following packages:

 @eslint/js                                            ^9.10.0  →   ^9.28.0
 @typescript-eslint/eslint-plugin                       ^8.6.0  →   ^8.33.1
 eslint-plugin-i18next                                  ^6.0.3  →    ^6.1.1
 eslint-plugin-import-x                                 ^4.2.1  →   ^4.15.0
 eslint-plugin-n                                      ^17.10.2  →  ^17.19.0
 eslint-plugin-prettier                                 ^5.2.1  →    ^5.4.1
 eslint-plugin-promise                                  ^7.1.0  →    ^7.2.1
 eslint-plugin-react                                   ^7.33.2  →   ^7.37.5
 eslint-plugin-react-hooks         ^5.1.0-rc-206df66e-20240912  →    ^5.2.0
Ensure the dev server continues running after ESLint errors during
compilation, avoiding the need for manual resets.

Prior to this change, the server hangs after an ESLint update due to
errors like:

```
<e> ✖ 1 problem (1 error, 0 warnings)
<e>
<e>     at makeWebpackError (/path/to/project/node_modules/webpack/lib/HookWebpackError.js:48:9)
<e>     at /path/to/project/node_modules/webpack/lib/Compilation.js:3364:12
<e>     at eval (eval at create (/path/to/project/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:31:1)
<e>     at /path/to/project/node_modules/webpack/lib/Compilation.js:594:27
<e>     at /path/to/project/node_modules/eslint-webpack-plugin/dist/index.js:159:11
<e> -- inner error --
<e>
<e> caused by plugins in Compilation.hooks.processAssets
```

See webpack/eslint-webpack-plugin#280
and #2353.
@coveralls
Copy link

coveralls commented Jun 4, 2025

Coverage Status

coverage: 62.742% (-26.2%) from 88.945%
when pulling 2eb7b75 on update-deps-20250603
into d9821a9 on master.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a changes entry. Otherwise, LGTM.

@dgdavid dgdavid merged commit aabb3fd into master Jun 5, 2025
6 of 7 checks passed
@dgdavid dgdavid deleted the update-deps-20250603 branch June 5, 2025 10:40
dgdavid added a commit that referenced this pull request Jun 5, 2025
The OBS build started failing after the removal of `eslint` in favor of
`@eslint/js`, despite the image building successfully during development
and testing in
[#2440](#2440). To restore
compatibility and fix the build, this change reintroduces `eslint` as a
direct dependency and updates it to the latest version.

Additionally, a related dependency has been patch-updated too.

---

Related to #2444
dgdavid added a commit that referenced this pull request Jun 9, 2025
Ensure Webpack doesn't crash on linter warnings during development,
similar to how linter errors were handled in PR #2440, commit a7f9c45.
@imobachgs imobachgs mentioned this pull request Jun 30, 2025
imobachgs added a commit that referenced this pull request Jun 30, 2025
dgdavid added a commit that referenced this pull request Aug 26, 2025
Update web dependencies to their latest versions except React and React
Router DOM and related ones, since both has published major versions
that should be updated in separated PRs with their corresponding
migrations after
PatternFly supports React 19.


---

Previous updates:

 * #2440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants