Skip to content

Meeting 2017 08 25 Frontend

Kai Xu edited this page Sep 8, 2017 · 1 revision

Participants

Present: Humzah, Kai

Agenda (to discuss)

  • Humzah to update the progress on text highlighting and its testing.

Discussion Points

  • Messaging between browserProvenance.js and historyMapPage.js using d3.dispatch (resolved)
  • Don't actually delete 'node' from the 'nodes' array, make it hidden instead.
  • Split the commits to meaningful small chunks, such as 'text highlighted', 'note node added', etc.
  • How to capture or create DOM for sinon testing: probably figure out how sinon use DOM first.
  • Remove the content.css and it seems OK, no error so far.
  • Merged rebuild-humzah with rebuild, so rebuild-humzah is up to date, but still have changes to be made.
  • By default, remove the unclear comments and unnecessary code from the 'master' branch. These can be added later if needed.

Action Points

  • Have a quick look (30 minutes) if there is any JS library for text highlighting and annotation.
  • Complete the highlight node removal.
  • Commit all the browser changes so far.
  • Add note hidden feature (so don't actually delete note).
  • Highlighting testing (virtual dom).
  • Fix edge testing.
Clone this wiki locally