Skip to content

Release v0.18.4#3113

Merged
TobiGr merged 276 commits intomasterfrom
dev
Feb 21, 2020
Merged

Release v0.18.4#3113
TobiGr merged 276 commits intomasterfrom
dev

Conversation

@Stypox
Copy link
Member

@Stypox Stypox commented Feb 19, 2020

New

Improved

Fixed


TODO


APK for testing: RC1

app-debug_RC1.zip
PLEASE REPORT NEW CRASHES IN THE CORRESPONDING ISSUE #3114

karkaminski and others added 30 commits January 14, 2020 22:23
/values-b+zh+HANS+CN was updated.
Action: copy file in /values-b+zh+HANS+CN to /values-zh-rCN
This allows fixing spurious playback resume when minimizing to the background player.
* add missing namespace of StandardCharsets
* use an unused constructor argument
This is a hardly reproduceable bug that I hopefully fixed. After a long time of watching videos, you could have your system language shown in playback parameters dialog.
Calling changeAppLanguage(getAppLocale(…),…) onCreate will most certainly fix this bug
After long clicking on a local playlist, show a dialog with 2 options for "rename" and "delete"
Rename shows another dialog to let the user rename the playlist.
Delete lets the user delete a playlist like before.
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 99.8% (526 of 527 strings)
Currently translated at 100.0% (527 of 527 strings)
Currently translated at 98.5% (519 of 527 strings)
@Poolitzer
Copy link
Member

upps.

@Poolitzer Poolitzer mentioned this pull request Feb 21, 2020
1 task
@Stypox
Copy link
Member Author

Stypox commented Feb 21, 2020

@Poolitzer fixed about #3102 ;-)

@Poolitzer
Copy link
Member

Good. I assumed that, so I moved it in the blogpost already (not that it matters this much)

auzkok and others added 15 commits February 21, 2020 16:57
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 99.6% (530 of 532 strings)
Currently translated at 99.6% (530 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 100.0% (532 of 532 strings)
Currently translated at 93.0% (495 of 532 strings)
Currently translated at 28.5% (152 of 532 strings)
Multiple localization fixes
Copy link
Member

@B0pol B0pol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f089cd0
I deleted live_duration_button translatable="false", and used live_duration instead, which is translatable.

All live_duration_button strings should be deleted (by ctrl-Fing in source, I find: values- cs, in, he, pl, ku, zh-rTW, tr).
I checked, for all of the quoted languages, live_duration is already translated so you can delete safely live_duration_button

@TobiGr
Copy link
Contributor

TobiGr commented Feb 21, 2020

@B0pol Thank you. Done
@Stypox Is there anything which prevents a release?

@Stypox
Copy link
Member Author

Stypox commented Feb 21, 2020

@TobiGr No, I don't think so, we should be good (the apk works and no problem has been reported) :-)

@TobiGr
Copy link
Contributor

TobiGr commented Feb 21, 2020

What the hell is going on. 👀 I cannot push to the dev branch. Worked without problems some minutes ago. Now I send endless data to GitHub, but nothing happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.