Rewrite ttml conversion#2957
Merged
TobiGr merged 6 commits intoTeamNewPipe:devfrom Jan 26, 2020
kapodamy:subtitles
Merged
Conversation
rewrite SubtitleConverter (use JSoup library instead, remove unused methods)
TobiGr
added
downloader
TobiGr
reviewed
Jan 17, 2020
app/src/main/java/org/schabi/newpipe/streams/SrtFromTtmlWriter.java
Outdated
Show resolved
Hide resolved
* add missing namespace of StandardCharsets * use an unused constructor argument
TobiGr
reviewed
Jan 20, 2020
app/src/main/java/org/schabi/newpipe/streams/SrtFromTtmlWriter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/streams/SrtFromTtmlWriter.java
Outdated
Show resolved
Hide resolved
TobiGr
approved these changes
Jan 26, 2020
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite SubtitleConverter (use JSoup library instead, remove unused methods)
fixes #2891