added ability to copy comments on long press#3053
Merged
TobiGr merged 4 commits intoTeamNewPipe:devfrom Feb 6, 2020
Merged
Conversation
Contributor
|
I don't think we need a settings option for this feature unless it is causing some performance hit. |
Contributor
Author
|
ok i'll remove it |
Member
|
How it works? Is it like description, you can select the area you want, or it copy the whole description? |
Contributor
Author
|
it copies the whole comment. i actually wanted to make it so that you can select the text, but the root view of the comment is clickable, so the the textview isn't selectable. |
yausername
suggested changes
Feb 4, 2020
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: yausername <5203007+yausername@users.noreply.github.com>
yausername
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to copy comments on long pressing them, and entry in the settings to enable/disable it.