Rename local playlist by long-clicking in BookmarkFragment.#2954
Merged
Stypox merged 9 commits intoTeamNewPipe:devfrom Feb 2, 2020
Merged
Rename local playlist by long-clicking in BookmarkFragment.#2954Stypox merged 9 commits intoTeamNewPipe:devfrom
Stypox merged 9 commits intoTeamNewPipe:devfrom
Conversation
After long clicking on a local playlist, show a dialog with 2 options for "rename" and "delete" Rename shows another dialog to let the user rename the playlist. Delete lets the user delete a playlist like before.
XiangRongLin
force-pushed
the
1907renamePlaylist
branch
from
de874a9 to
77aa12d
Compare
TobiGr
reviewed
Feb 1, 2020
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you. one small thing
app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
Outdated
Show resolved
Hide resolved
Contributor
What do you mean exactly? Can you post two screenshots please? |
Collaborator
Author
|
thin dialog |
Member
|
Maybe you need to add some padding (or inset) to the view? |
…look. Use "rename" string instead of "save" string.
Collaborator
Author
|
Padding doesn't work, it makes the the content start further in the middle from the dialog box. A way i found is using AlertDialog instead of Dialog. |
Stypox
added
feature request
Contributor
|
Yes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing #2309, i decided to copy the ui for editing and deleting a playlist.
Something i coulnd't figure out was why the dialog is thinner than the deletion-confirmation-dialog.
I tested it on my Pixel with android 10 and old phone with android 7.
Fixes #1907
app-debug.zip