ask for display over other apps permission in settings#3004
Merged
TobiGr merged 5 commits intoTeamNewPipe:devfrom Feb 1, 2020
Merged
ask for display over other apps permission in settings#3004TobiGr merged 5 commits intoTeamNewPipe:devfrom
TobiGr merged 5 commits intoTeamNewPipe:devfrom
Conversation
TobiGr
added
bug
Contributor
|
Please re-format your code to increase readability. |
Contributor
Author
|
is this ok? |
Stypox
requested changes
Jan 28, 2020
app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java
Outdated
Show resolved
Hide resolved
Stypox
previously approved these changes
Jan 28, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2922 - This issue seems to happen on any device on Android 6 and above. Specifically on Android 10, it seems like it doesn't open the Settings window for the permission when the home button is pressed. But even in cases where it does show the window, it won't open the popup window when you give it the permission.
So i added a snackbar that lets the user go to the settings when they set the "minimise on home" option to "minimise to popup player".