feat: auto-refresh marketplace data when organization settings change

[roomote]

This PR implements automatic marketplace data refresh when organization settings are updated in the cloud.

Changes Made

• Added organizationSettingsVersion to the ExtensionState type to track version changes
• Modified ClineProvider to include the organization settings version in state sent to webview
• Updated the CloudService callback in extension.ts to trigger marketplace refresh when settings change
• Added logic to MarketplaceView component to detect version changes and request data refresh
• Created comprehensive tests for the new functionality

How It Works

1. When organization settings are updated in the cloud, the version field increments
2. The CloudService detects this change and triggers its callback
3. The callback now calls both postStateToWebview() and fetchMarketplaceData()
4. The MarketplaceView component detects the version change via a useEffect hook
5. When a version change is detected, it sends a fetchMarketplaceData message to refresh the data

Testing

• Added unit tests for the MarketplaceView version change detection
• All existing tests pass
• Linting and type checking pass

This ensures marketplace items (MCPs and modes) stay in sync when organization settings are updated, providing a better user experience.

---

Important

Introduces auto-refresh of marketplace data in MarketplaceView when organization settings change, with state management and testing updates.

• Behavior:
  • Adds organizationSettingsVersion to ExtensionState in ExtensionMessage.ts to track version changes.
  • Updates ClineProvider in ClineProvider.ts to include organizationSettingsVersion in state sent to webview.
  • Modifies MarketplaceView in MarketplaceView.tsx to detect version changes and request data refresh.
  • Updates extension.ts to trigger marketplace refresh when settings change.
• Testing:
  • Adds unit tests in MarketplaceView.spec.tsx to verify marketplace data fetch on version change.
  • Ensures no fetch is triggered if version remains the same.
• Misc:
  • Updates useStateManager.ts to handle state changes more efficiently.

^{This description was created by for 8b9cb8f. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Thank you for your contribution! I've reviewed the changes and found some issues that need attention. The implementation correctly addresses the requirement to auto-refresh marketplace data when organization settings change, and the approach using version tracking is sound.

[roomote]

Would it be beneficial to add more explicit typing here to distinguish between undefined (not available) and number (valid version)? This could improve type safety throughout the application.

[jr]

@roomote

1. The other CloudService values are fetched in getState(). Could you locate this next to them?
2. Using undefined has gotten us into trouble sometimes. Please use -1 if CloudService is not available or there are no settings.
3. Undo the changes to await CloudService.createInstance(context, {. The webview-ui code is responsible for asking for marketplace data on demand.

[roomote]

Thanks for the feedback @jr! I'll address all three points:

1. Move the CloudService value fetching to getState() alongside other CloudService values
2. Use -1 instead of undefined when CloudService is not available
3. Undo the changes to CloudService.createInstance callback

Working on these changes now.

[roomote]

✅ Changes implemented as requested:

1. Moved CloudService value fetching to getState(): Relocated organizationSettingsVersion fetching from getStateToPostToWebview() to getState() alongside other CloudService values (organizationAllowList, cloudUserInfo, etc.)

2. Using -1 instead of undefined: Updated the logic to return -1 when CloudService is not available or there are no settings, instead of undefined. This prevents potential issues with undefined values.

3. Removed fetchMarketplaceData() from CloudService callback: Undid the changes to await CloudService.createInstance(context, { in extension.ts. The webview-ui code is now responsible for asking for marketplace data on demand as intended.

4. Updated MarketplaceView.tsx: Modified the component to properly handle -1 as the "no settings" case instead of undefined.

Testing:

• ✅ All existing tests pass (MarketplaceView.spec.tsx and ClineProvider.spec.ts)
• ✅ Linting and type checking pass
• ✅ CI checks are running

The auto-refresh functionality is preserved while addressing all the architectural concerns raised in the review.

[jr]

@roomote

1. In webview-ui/src/context/ExtensionStateContext.tsx can you make organizationSettingsVersion simply a number and default it to -1. I think you can simplify or remove the "should not trigger fetchMarketplaceData when organization settings version is undefined" test once that's done.
2. In webview-ui/src/components/marketplace/MarketplaceView.tsx can you simplify the fetch check to just currentVersion !== lastOrganizationSettingsVersion?

[roomote]

👋 I see your feedback @jr! Working on implementing both changes:

1. Making organizationSettingsVersion simply a number with default -1 in ExtensionStateContext.tsx
2. Simplifying the fetch check to just currentVersion !== lastOrganizationSettingsVersion in MarketplaceView.tsx

I will also update/remove the related test as suggested. Starting implementation now!

[roomote]

✅ Changes implemented successfully!

I have implemented both requested changes:

1. Made organizationSettingsVersion simply a number with default -1 in ExtensionStateContext.tsx:

   • Changed type from number | undefined to number
   • Set default value to -1 in initial state
   • Added fallback to -1 in context value

2. Simplified the fetch check in MarketplaceView.tsx:

   • Removed complex conditional logic
   • Now uses simple currentVersion !== lastOrganizationSettingsVersion comparison

3. Updated the test in MarketplaceView.spec.tsx:

   • Replaced "should not trigger fetchMarketplaceData when organization settings version is undefined" test
   • New test verifies behavior when transitioning from -1 to a valid version number

Testing Results:

• ✅ All MarketplaceView tests pass (3/3)
• ✅ TypeScript compilation successful
• ✅ ESLint checks pass
• ✅ CI checks are running and progressing normally

The code is now cleaner and more predictable without the undefined state handling complexity.

[daniel-lxs]

LGTM