fix(environment): Filter out non-text tab inputs

[hassoncs]

Bug Description

Multi-file edit operations (apply_diff tool) would fail consistently when Git diff views were open in VSCode. The failure occurred before reaching the diff view opening code, indicating the issue was not with tab management as initially suspected.

Root Cause

The bug was caused by environment context contamination in src/core/environment/getEnvironmentDetails.ts. When Git diff views are open, the environment details gathering code was incorrectly processing non-text tabs:

1. Improper type casting: Line 68 used (tab.input as vscode.TabInputText)?.uri?.fsPath without filtering, casting all tab inputs as TabInputText regardless of their actual type
2. Processing incompatible tab types: Git diff tabs have input types like TabInputTextDiff, not TabInputText
3. Malformed environment data: This resulted in unexpected/malformed data being included in the environment context sent to the AI
4. AI parsing interference: The contaminated context affected how the AI parsed multi-file apply_diff requests, causing them to fail

Fix

Added proper tab type filtering before processing:

// Before (BROKEN)
.map((tab) => (tab.input as vscode.TabInputText)?.uri?.fsPath)

// After (FIXED)
.filter((tab) => tab.input instanceof vscode.TabInputText)
.map((tab) => (tab.input as vscode.TabInputText).uri.fsPath)

This matches the correct pattern already used in other parts of the codebase like DiffViewProvider.ts and WorkspaceTracker.ts.

Impact

• Multi-file edits now work reliably when Git diff views are open
• Environment context data is properly filtered and type-safe
• Consistent tab processing across the codebase

Fixes: Kilo-Org/kilocode#712

---

Important

Fixes environment context contamination in getEnvironmentDetails.ts by filtering non-text tab inputs, ensuring reliable multi-file edits with Git diff views open.

• Bug Fix:
  • Fixes environment context contamination in getEnvironmentDetails.ts by filtering non-text tab inputs.
  • Ensures only vscode.TabInputText instances are processed, preventing malformed data.
• Code Changes:
  • Adds .filter((tab) => tab.input instanceof vscode.TabInputText) before mapping tab inputs in getEnvironmentDetails.ts.
• Impact:
  • Multi-file edits work reliably with Git diff views open.
  • Consistent and type-safe environment context data.

^{This description was created by for aa85bc8. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Code Review Summary

This PR effectively fixes the environment context contamination issue that was causing multi-file edit operations to fail when Git diff views were open. The fix is well-targeted and follows established patterns in the codebase.

Critical Issues (Must Fix):

1. Missing test coverage for tab filtering fix
The existing test file src/core/environment/__tests__/getEnvironmentDetails.spec.ts does not test the specific scenario that caused the bug (non-text tab inputs like Git diff views). Should we add a test case that mocks TabInputTextDiff tabs to ensure this regression does not happen again?

Important Suggestions (Should Consider):

2. Consider adding TypeScript type guards
While the fix works correctly, could we create a reusable type guard function like isTabInputText(tab): tab is vscode.TabInputText to make the intent clearer and potentially reuse this pattern elsewhere in the codebase?

Minor Improvements (Nice to Have):

3. Changeset description could be more specific
The current changeset mentions "failure to apply changes to files" but could be more precise about the Git diff view trigger for better release notes.

Positive Observations:

• The fix correctly matches the established pattern used in DiffViewProvider.ts:94 and WorkspaceTracker.ts:80
• The root cause analysis in the PR description is excellent and clearly explains the environment context contamination issue
• The fix is minimal and surgical, addressing exactly the problem without over-engineering
• The issue reproduction steps provided by @hassoncs were crucial for identifying this bug

The core fix is solid and addresses the immediate issue effectively. The suggestions above are primarily about improving robustness and maintainability for the future.

[mrubens]

Thank you for tracking this down!