-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Enhanced navigation filters #36049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
257698a to
b271581
Compare
🦋 Changeset detectedLatest commit: 0130d8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a74114a to
8a68b06
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36049 +/- ##
=========================================
Coverage 65.78% 65.79%
=========================================
Files 3231 3256 +25
Lines 108114 108451 +337
Branches 20573 20674 +101
=========================================
+ Hits 71126 71352 +226
- Misses 34326 34439 +113
+ Partials 2662 2660 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5b6ba4d to
f9895a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When navigating to admin, or to any of the user preferences page (feature preview, accessibility, etc), the sidepanel keeps open despite the regular sidebar not being visible anymore:

You can also notice that one of the items has a message preview undefined. That message is an encrypted message and I have not set my key.
apps/meteor/client/views/navigation/contexts/RoomsNavigationContext.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/navigation/providers/RoomsNavigationProvider.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/Sidepanel/SidepanelItem/useParentDiscussionData.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/Sidepanel/SidepanelItem/useParentTeamData.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/Sidepanel/SidepanelItem/useParentTeamData.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/Sidepanel/SidepanelItem/useParentTeamData.ts
Outdated
Show resolved
Hide resolved
714bda5 to
42d2fba
Compare
42d2fba to
8d6e57f
Compare
8d6e57f to
78653b6
Compare
4a59e2d to
c6c28ed
Compare
a8a1953 to
0130d8d
Compare
Proposed changes (including videos or screenshots)
Important
This change is under feature preview
This PR adds a brand new approach to filter rooms on the side navigation
Issue(s)
SIDE2-6
Steps to test or reproduce
Further comments