Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented May 21, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Kapture 2025-07-31 at 12 05 18

This PR adds a brand new approach to filter rooms on the side navigation

  • It introduces the All filter, where all conversations you're participating will be displayed
  • Mentions, where the conversations where you received mentions will be displayed
  • Favorites, where the conversations you mark as favorite will be displayed
  • Discussions, will display all discussions you're participating
  • Omnichannel filters, containing In progress, On hold and Queue options
  • Teams, channels and DMs filters, where the conversations related to that room will be displayed

Issue(s)

SIDE2-6

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36049/

Built to branch gh-pages at 2025-08-15 03:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 257698a to b271581 Compare May 22, 2025 21:36
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 0130d8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/mock-providers Minor
@rocket.chat/core-services Minor
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/ui-client Major
@rocket.chat/models Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/network-broker Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/apps Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris force-pushed the feat/sidebar-filters branch 4 times, most recently from a74114a to 8a68b06 Compare May 28, 2025 17:44
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

❌ Patch coverage is 78.14010% with 181 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.79%. Comparing base (575f3df) to head (0130d8d).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #36049    +/-   ##
=========================================
  Coverage    65.78%   65.79%            
=========================================
  Files         3231     3256    +25     
  Lines       108114   108451   +337     
  Branches     20573    20674   +101     
=========================================
+ Hits         71126    71352   +226     
- Misses       34326    34439   +113     
+ Partials      2662     2660     -2     
Flag Coverage Δ
e2e 57.18% <73.16%> (+0.03%) ⬆️
unit 71.25% <85.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris force-pushed the feat/sidebar-filters branch 4 times, most recently from 5b6ba4d to f9895a9 Compare May 29, 2025 21:22
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When navigating to admin, or to any of the user preferences page (feature preview, accessibility, etc), the sidepanel keeps open despite the regular sidebar not being visible anymore:
image

You can also notice that one of the items has a message preview undefined. That message is an encrypted message and I have not set my key.

@dougfabris dougfabris force-pushed the feat/sidebar-filters branch 2 times, most recently from 714bda5 to 42d2fba Compare June 5, 2025 19:30
@dougfabris dougfabris changed the title feat: Sidebar Filters feat: Enhanced navigation filters Jun 6, 2025
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 42d2fba to 8d6e57f Compare June 6, 2025 13:28
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 8d6e57f to 78653b6 Compare June 6, 2025 13:32
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from 4a59e2d to c6c28ed Compare June 13, 2025 20:39
@dougfabris dougfabris force-pushed the feat/sidebar-filters branch from a8a1953 to 0130d8d Compare August 15, 2025 16:53
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 15, 2025
@ggazzo ggazzo merged commit c7db598 into develop Aug 15, 2025
125 of 131 checks passed
@ggazzo ggazzo deleted the feat/sidebar-filters branch August 15, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants