Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 19, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-132

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 19, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2025

⚠️ No Changeset found

Latest commit: eb4382e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title fix: Sidepanel being empty when no subscription regression: Sidepanel being empty when no subscription Aug 19, 2025
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.77%. Comparing base (9650020) to head (eb4382e).
⚠️ Report is 3 commits behind head on reg/sidebar-filters-issues.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           reg/sidebar-filters-issues   #36752      +/-   ##
==============================================================
- Coverage                       65.77%   65.77%   -0.01%     
==============================================================
  Files                            3256     3256              
  Lines                          108519   108518       -1     
  Branches                        20680    20679       -1     
==============================================================
- Hits                            71375    71374       -1     
  Misses                          34480    34480              
  Partials                         2664     2664              
Flag Coverage Δ
e2e 57.16% <0.00%> (-0.02%) ⬇️
unit 71.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo marked this pull request as ready for review August 19, 2025 20:47
@ggazzo ggazzo requested a review from a team as a code owner August 19, 2025 20:47
@ggazzo ggazzo merged commit 756154e into reg/sidebar-filters-issues Aug 19, 2025
49 of 51 checks passed
@ggazzo ggazzo deleted the reg/sidepanel-empty-subscription branch August 19, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants