Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 18, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Introduced here: #36049

The product design team decided we should not make the SidePanelParentTag redirects to its room

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-129

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 18, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2025

⚠️ No Changeset found

Latest commit: 71b5ef9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.10.0 milestone Aug 18, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c7db598) to head (71b5ef9).
⚠️ Report is 8 commits behind head on reg/sidebar-filters-issues.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           reg/sidebar-filters-issues   #36739      +/-   ##
==============================================================
+ Coverage                       65.77%   65.84%   +0.07%     
==============================================================
  Files                            3256     3257       +1     
  Lines                          108464   108520      +56     
  Branches                        20667    20683      +16     
==============================================================
+ Hits                            71340    71457     +117     
+ Misses                          34465    34390      -75     
- Partials                         2659     2673      +14     
Flag Coverage Δ
e2e 57.20% <100.00%> (+0.02%) ⬆️
e2e-api 35.88% <ø> (+0.32%) ⬆️
unit 71.27% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review August 19, 2025 12:05
@dougfabris dougfabris requested a review from a team as a code owner August 19, 2025 12:05
@dougfabris dougfabris changed the base branch from develop to reg/sidebar-filters-issues August 19, 2025 15:23
@dougfabris dougfabris merged commit 9650020 into reg/sidebar-filters-issues Aug 19, 2025
85 of 89 checks passed
@dougfabris dougfabris deleted the reg/sidepanelitem-redirect branch August 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants